Time
S
Nick
Message
10:42 romainM joined #dataverse
12:25 michbarsinai joined #dataverse
12:26 michbarsinai
@pdurbin: Hello! quick question
12:44 pdurbin_m joined #dataverse
12:44 pdurbin_m
michbarsinai: yes?
12:45 michbarsinai
I lost track on the large file thing (too busy on the DataTags class). Was that the reason for the latest prod issues?
12:46 michbarsinai
I saw you were praised in the email thread talking about it :-)
12:46 pdurbin_m
well, Leonid and Kevin are the real heroes
12:47 pdurbin_m
check your email. "Production" thread for my latest thoughts
12:47 michbarsinai
Yes, the dashborad, right? Also, thanks for the Time piece. Will be an interesting read
12:52 michbarsinai
pdurbin: are there any offloading/microservice solutions being discussed at the moment?
13:00 pdurbin_m
michbarsinai: dunno. hey, can I please get some code review of https://github.com/IQSS/dataverse/commit/6f8ee3a00d1915f3f3d2a2cb0e019812a91f10fe
13:01 michbarsinai
Sure
13:02 michbarsinai
OK, I'm there
13:06 pdurbin_m
michbarsinai: is that how you'd fix the regression?
13:07 michbarsinai
That
13:07 michbarsinai
's one way of doing it. I think I might have gone with another way,
13:07 michbarsinai
as this one is very state-ful
13:08 michbarsinai
so, the httprequest is kept around in a field. I don't see how it can be exploited, though.
13:08 michbarsinai
But still, even if there's no security issue it cannot be garbage collected.
13:09 michbarsinai
Can you add the HttpRequest as a parameter to the method the client code is calling?
13:09 michbarsinai
This way, the service bean won't need to refere to JSF context
13:10 michbarsinai
Basically, the same logic (JSF gets special treatment) but with the if and state removed.
13:18 pdurbin_m
michbarsinai: any interest in making a pull request?
13:19 michbarsinai
Interest - yes. I have a conference on Tuesday, so no bandwidth at all :-(
13:20 michbarsinai
Can do that later, maybe, but I've never looked at this part.
13:20 michbarsinai
How many entry points? Is it complext to set up?
13:33 pdurbin_m
michbarsinai: you'd want to do a "find usages" on the method I changed
13:34 pdurbin_m
https://github.com/IQSS/dataverse/issues/2718 has a lot of notes
13:38 michbarsinai
ok, Sending a mail to the list and taking the kid from practice. See ya!
13:38 michbarsinai left #dataverse
20:16 axfelix joined #dataverse
21:27 bencomp joined #dataverse
23:03 * pdurbin
adds the image in that mail to https://github.com/IQSS/dataverse/issues/2728#issuecomment-156491229 :)
23:18 axfelix joined #dataverse
