Time
S
Nick
Message
00:11 djbrooke joined #dataverse
00:59 axfelix joined #dataverse
01:00 axfelix joined #dataverse
02:08 kzisme joined #dataverse
02:08 kzisme joined #dataverse
04:40 LyndsySimon joined #dataverse
04:41 skay_ joined #dataverse
04:57 skay joined #dataverse
05:05 JonathanNeal joined #dataverse
05:14 jeffspies______ joined #dataverse
06:08 djbrooke joined #dataverse
07:26 jri joined #dataverse
07:27 jri joined #dataverse
09:03 kzisme joined #dataverse
10:38 pdurbin joined #dataverse
10:44 jo-pol joined #dataverse
10:45 jo-pol left #dataverse
12:08 donsizemore joined #dataverse
12:58 pameyer joined #dataverse
13:01 pdurbin
donsizemore pameyer: good morning!
13:04 pameyer
pdurbin: morning, and welcome back!
13:06 pameyer
thought you were still on vacation
13:07 pdurbin
nope, yesterday was the last day of vacation: https://twitter.com/philipdurbin/status/771055053415280640 :)
13:10 pdurbin
pameyer: it sounds like Bill got a lot of feedback on the DCM last Thurday
13:11 pameyer
he did - did you see the doc?
13:11 pdurbin
I made a note just now to review the doc.
13:23 majest1c joined #dataverse
13:24 pdurbin
I'm catching up on email first. Then Slack.
13:24 pameyer
there's always a backlog
13:25 pdurbin
I'm also a bit troubled by this: Breaking change to API ? · Issue #3326 · IQSS/dataverse - https://github.com/IQSS/dataverse/issues/3326
13:26 pameyer
huh - I hadn't seen that one
13:27 pdurbin
I'll run my integration tests in a bit.
13:32 bsilverstein joined #dataverse
13:33 pdurbin
My "phoenix" tests, which I'm happy to explain if anyone is curious.
13:34 bsilverstein
pdurbin: welcome back!
13:34 pdurbin
bsilverstein: thanks! I see you got some feedback from QA on your pull request!
13:35 bsilverstein
pdurbin: I did, only one hefty bug as of yesterday -- gonna hopefully fix it by EOD
13:47 pdurbin
bsilverstein: awesome
13:48 pdurbin
pameyer: Danny just mentioned that you and Bill aren't coming over today so I deleted the calendar entry.
13:48 djbrooke joined #dataverse
13:49 pdurbin
speak of the devil, here's djbrooke ;)
13:52 pdurbin
bsilverstein: what's the status of https://github.com/IQSS/dataverse/tree/3300-confirm-email-restrictions ?
13:53 djbrooke joined #dataverse
13:54 bsilverstein
pdurbin: haven't made it as far as I'd like to with that, think I'm gonna focus for now on ironing out the QA stuff from the pull request
13:56 pdurbin
ok
14:06 djbrooke_ joined #dataverse
14:07 pdurbin
bsilverstein: are you hopeful it'll get merged before your last day tomorrow?
14:08 bsilverstein
pdurbin: the first pull request? could happen! got plenty to knock out first though
14:11 pdurbin
bsilverstein: hurry! ;)
14:11 pdurbin
bsilverstein: do you need me to help with anything?
14:12 bsilverstein
pdurbin: actually one thing you could definitely help with and have an easier time than me is the yellow alert Kevin mentioned in the QA notes
14:13 bsilverstein
he suggested having that alert tell the user to check their inbox at whatever email they are using
14:13 axfelix joined #dataverse
14:13 pdurbin
bsilverstein: show the email address in the yellow alert?
14:13 donsizemore joined #dataverse
14:14 bsilverstein
pdurbin: yeah, currently it says:
14:14 bsilverstein
Info – Your account information has been successfully updated. Your email address changed and must be re-confirmed. Also, please note that the link will only work for the next 1 minute before it has expired.
14:15 bsilverstein
but he suggested adding in the user's address cause the banner never actually says where the mentioned link is
14:16 pdurbin
bsilverstein: sounds like good feedback. Are you still using TODOs in the Google Doc?
14:18 bsilverstein
pdurbin: as in recording todos there? not really
14:19 pdurbin
bsilverstein: please keep cranking away and check with me in a few hours to see if I'm caught up enough to help.
14:21 bsilverstein
pdurbin: certainly!
14:22 pdurbin
I'm still on the 3153-2419-lockuser branch with some hopefully final finishing touches I'm working on before I make a pull request.
14:23 pdurbin
djbrooke_: I'll be checking in with you soon about the lockuser/password guessing feature
14:29 djbrooke joined #dataverse
14:32 djbrooke joined #dataverse
14:37 djbrooke joined #dataverse
14:41 nicholas_ joined #dataverse
14:51 djbrooke joined #dataverse
14:56 djbrooke joined #dataverse
14:59 sekmiller joined #dataverse
15:31 donsizemore joined #dataverse
15:46 djbrooke joined #dataverse
15:48 djbrooke joined #dataverse
15:54 djbrooke_ joined #dataverse
16:19 donsizemore joined #dataverse
17:17 djbrooke joined #dataverse
17:52 djbrooke joined #dataverse
18:08 donsizemore joined #dataverse
18:23 pdurbin
pameyer: still there?
18:23 pameyer
yup
18:24 pdurbin
pameyer: do you or Bill need anything from me?
18:24 pameyer
of course :)
18:24 pdurbin
heh
18:24 pdurbin
today? :)
18:25 pameyer
but I don't think anything that has to happen today
18:28 djbrooke joined #dataverse
18:33 djbrooke joined #dataverse
18:40 djbrooke joined #dataverse
18:48 pdurbin
oh good
18:49 pdurbin
pameyer: do you need me to do anything before the demo?
19:35 donsizemore joined #dataverse
19:53 bsilverstein
pdurbin: as per the strikethroughs on the todo list: render bug fixed, info message changed to success/specified, and bundle warning added
19:53 bsilverstein
may yet live to see my own pull request merged!
20:13 djbrooke joined #dataverse
20:17 pdurbin
bsilverstein: nice! Please let me know when you push
20:19 bsilverstein
pdurbin: has been pushed to 2170 branch
20:20 pdurbin
bsilverstein: nothing has been pushed for 8 days: https://github.com/IQSS/dataverse/branches/active
20:20 pdurbin
(on any branch)
20:21 bsilverstein
*eyebrow raise*
20:21 bsilverstein
must have goofed and pushed to my own branch
20:21 pdurbin
oh
20:22 bsilverstein
maybe now? just tried again and made sure it was updating origin/confirm-email-2170
20:23 bsilverstein
still no dice apparently. what the heck
20:33 bsilverstein
pdurbin: oh wait duh. local branch is still 3300
20:35 djbrooke joined #dataverse
20:35 pdurbin
bsilverstein: I gotta run
20:39 pdurbin
bsilverstein: but ask I mentioned you could try doing git cherry-pick from one branch to the other
20:39 bsilverstein
for sure, will give that a try
20:43 bsilverstein
pdurbin: commit 46a21b5f42 successfully cherry picked! *now* I can push. seeya tomorrow!
20:54 pameyer joined #dataverse
21:10 djbrooke joined #dataverse
22:30 axfelix joined #dataverse
22:31 axfelix joined #dataverse
22:46 garnett joined #dataverse
