Time
S
Nick
Message
02:15 bjonnh
I have to think about this whole thing
02:16 bjonnh
is there any rationale behind not having a directory structure?
02:25 axfelix joined #dataverse
03:20 axfelix joined #dataverse
04:25 axfelix joined #dataverse
12:03 donsizemore joined #dataverse
13:00 pdurbin
bjonnh: I don't know. That decision was made before my time. Can you please give me some feedback on what I wrote at https://github.com/IQSS/dataverse/issues/2249#issuecomment-244370569 ? I just want to know if what I wrote makes sense.
13:08 dataverse-user joined #dataverse
13:24 skay joined #dataverse
13:24 skay joined #dataverse
13:33 pameyer joined #dataverse
14:04 pameyer
bjonnh: directory structure was something that jumped out at me too
14:20 pdurbin
pameyer: it's a gotcha :)
15:06 bjonnh
pdurbin: why not associating a folder to a specific version of a file then?
15:52 pdurbin
bjonnh: that's exactly what https://github.com/IQSS/dataverse/pull/3412 was about
16:22 bjonnh
oh I see
16:22 bjonnh
I like the idea
16:22 bjonnh
so you can make up zip files on the fly
16:22 bjonnh
and maybe make up rsync on the fly
16:27 pdurbin
bjonnh: in the future, we'd like to. Yes. If you want you could create an issue about this. Something like "create a zip file on the fly using the new "directorylabel" field added in pull request #3412". This is actually a feature we had in DVN 3.6. Undocumented from what I can tell.
16:28 pdurbin
In the "3.6 & 4.0 Feature Comparison" doc at https://docs.google.com/spreadsheets/d/1ftHM6E4b9Dft_AvA6KTzeklJyLguItz2_0hNAFL8-VM/edit?usp=sharing it's called "Download as zip while preserving directory structure"
17:22 donsizemore joined #dataverse
17:32 bjonnh
pdurbin: #3448
17:34 pameyer
rsync uploads (and DCM in general) preserve directory hierarchy; that was one of our reasons for doing it
17:34 pameyer
making it work with versions is something that we're working on
18:16 bjonnh
arg
18:16 bjonnh
I can't use virtualbox on this machine
18:16 bjonnh
so I can't use the vagrant script
18:42 pdurbin
bjonnh: https://github.com/IQSS/dataverse/issues/3448 looks great. Thanks!
18:43 pdurbin
pameyer: I forget if we've linke bjonnh to the DCM/rsync issue: https://github.com/IQSS/dataverse/issues/3145
18:43 pameyer
I'll trust your memory on that over mine
18:44 bjonnh
I'm making a docker
18:44 bjonnh
that's using the vagrant files
18:45 bjonnh
because the docker I found are using copy and paste of the script
18:45 bjonnh
s
18:50 pdurbin
bjonnh: are you using telnoratti's docker? You probably should: https://github.com/IQSS/dataverse-aws
18:51 telnoratti
bjonnh: we tried to deviate as little as possible from upstream to make the docker files. I'd be happy to help make them work for you.
18:52 bjonnh
oh
18:52 telnoratti
they're at vtti/dataverse and vtti/dataverse-solr if can't be bothered to build them
18:52 telnoratti
I've been meaning to get to a docker compose with those, but haven't had time
18:53 pdurbin
telnoratti: should we ask bjonnh to build new ones (containers? images?) for Dataverse 4.5.1? To make a pull request? :)
18:54 telnoratti
oh it's not on the latest version
18:54 telnoratti
I didn't realize
18:54 telnoratti
he's welcome to make a pull request, it should be as simple as changing line 53 in docker/glassfish/Dockerfile
18:55 telnoratti
pdurbin: does that have the updated install script in it?
18:55 pdurbin
telnoratti: yep
18:55 bjonnh
I have to see how I could use telnoratti thing
18:55 bjonnh
that's just for dev on my local machine
18:56 bjonnh
so your thing is made using two containers
18:57 bjonnh
I see
18:57 bjonnh
hmm
18:57 telnoratti
there's an example usage https://github.com/IQSS/dataverse-aws/blob/master/dataverse.json#L901-L922
18:57 bjonnh
yeah I found that
18:57 telnoratti
though a bit convoluted, thanks cloudformations
18:58 telnoratti
that's a fully automated deployment for aws if you want to try it
18:59 telnoratti
the DB is using RDS, so if you want to do it locally, you'll need to be sure you have a postgres instance available
19:05 pameyer
the conversation swinging back to docker reminded me that I wasn't sure why dataverse was doing asadmin commands in the install script instead of "here's an example domain.xml"
19:08 bjonnh
I don't have aws
19:08 pameyer
bjonnh: what OS (es) are you using?
19:08 bjonnh
archlinux
19:08 bjonnh
but in docker I can put whatever I want
19:09 pameyer
ok. from your "no virtualbox" comment I was wondering if you were on non-unix
19:10 pdurbin
pameyer: we used to supply a domain.xml template in the DVN 3.x days. Using `asadmin` commands it much better. It's scriptable. Repeatable.
19:10 pdurbin
That said you're welcome to hack away at that XML file if you want.
19:10 bjonnh
I'm making a dockerfile that uses the vagrant scripts directly
19:10 bjonnh
so that way I have no need to tweak anything else
19:15 bjonnh
especially since I want to be able to test my code quickly
19:15 bjonnh
and not rebuild everything every time
19:19 bjonnh
its building, lets see what happens
19:20 bjonnh
it is basically taking the branch you ask it to from git
19:20 bjonnh
and running the vagrant setup scripts
19:22 pdurbin
telnoratti: how does that grab you?
19:23 pdurbin
bjonnh: what if we could deploy an arbitrary branch (say the one with your future pull request in it) to AWS?
19:24 bjonnh
I would need an AWS access
19:24 bjonnh
which I don't have
19:25 bjonnh
to test that
19:25 bjonnh
but that would be possible in theory
19:26 pdurbin
bjonnh: cool. I have an AWS account (now) but I haven't had time to start using it. :)
19:26 bjonnh
:P
19:26 pdurbin
see "AWS" at https://groups.google.com/d/msg/dataverse-community/tDjFfGQ-f0Q/EhEVDVzMAQAJ
19:38 axfelix joined #dataverse
19:44 telnoratti
pdurbin: yeah, whatever the best way to build dataverse from a commit is fine by me
20:09 djbrooke joined #dataverse
20:23 djbrooke joined #dataverse
20:26 djbrooke joined #dataverse
20:37 djbrooke joined #dataverse
20:37 djbrooke joined #dataverse
20:54 axfelix joined #dataverse
21:13 djbrooke joined #dataverse
21:21 pdurbin_m joined #dataverse
21:22 pdurbin_m
telnoratti: well, `mvn package` is enough to build the war file. We do this in Travis already.
21:24 pdurbin_m
hmm, `mvn test` at least: https://github.com/IQSS/dataverse/blob/develop/.travis.yml
21:25 pdurbin_m
you probably mean everything... postgres, solr etc
21:26 donsizemore joined #dataverse
21:32 djbrooke joined #dataverse
22:39 djbrooke joined #dataverse
