IRC log for #dataverse, 2017-06-30

Connect via chat.dataverse.org to discuss Dataverse (dataverse.org, an open source web application for sharing, citing, analyzing, and preserving research data) with users and developers.

All times shown according to UTC.

Time	Nick	Message
00:01		axfelix joined #dataverse
00:04		garnett joined #dataverse
00:38		axfelix joined #dataverse
03:40		axfelix joined #dataverse
04:20		jri joined #dataverse
07:08		jri joined #dataverse
08:46		jri joined #dataverse
11:52		donsizemore joined #dataverse
13:46		donsizemore joined #dataverse
13:48	pdurbin	bjonnh bret bricas donsizemore jri: Help Wanted: stories related to "Submit for Review" and "Return to Author" - Google Groups - https://groups.google.com/forum/#!msg/dataverse-community/bGlCU2pbQpE/h3d9enX9AAAJ
14:03	bjonnh	I don't think I can access the google group
14:03	bjonnh	oh yes I can nevermind
14:04	bjonnh	pdurbin: ok I'm sending that in the lab
14:43		pameyer joined #dataverse
14:58		donsizemore joined #dataverse
15:44		jhand joined #dataverse
16:35		bsilverstein joined #dataverse
16:44		jri joined #dataverse
16:45		donsizemore joined #dataverse
18:02		bsilverstein joined #dataverse
18:13	pdurbin	bjonnh: you're going to send that around to actual end users? Thanks!
18:13	pdurbin	I swear the grumpy curator in the cartoon I drew is not pameyer
18:13	pameyer	:)
18:14	pameyer	I still might use it for my github icon though
18:14	pdurbin	pameyer: I would be honored!
18:48	pdurbin	pameyer: question about https://github.com/IQSS/dataverse/issues/3974
18:49	pdurbin	nevermind! https://github.com/IQSS/dataverse/pull/3975 answers my question! :)
18:50	pdurbin	pameyer: you did however, miss a very important step: http://guides.dataverse.org/en/4.7/developers/version-control.html#make-sure-your-pull-request-has-been-advanced-to-code-review
19:35	pameyer	pdurbin: good point; I didn't want to distract anybody
19:35	pameyer	looks like I didn't do a great job of that
19:41	pdurbin	pameyer: you have the power to move it, right?
19:42	pdurbin	pameyer: oh, you should read this too if you haven't already: https://github.com/IQSS/dataverse/blob/v4.7/CONTRIBUTING.md#codepull-requests
19:42	pdurbin	I hope those two documents don't contradict each other.
19:43	pameyer	moved it
19:43	pameyer	I was actually looking at 3946, and got reminded about fixing 3974
19:51	pdurbin	pameyer: why don't you run `make clean` instead?
20:13	pameyer	`mvn clean` + `make clean` vs have `mvn clean` run `make clean` for me?
20:13	pameyer	seemed to make more sense to fix it so that developers don't have to remember two steps
20:14	pdurbin	well, you just typed `make` right? it's natural to type `make clean` when you're done
20:15	pameyer	make is supposed to be smart enough to only rerun when it's dependencies have changed
20:15	pameyer	makefile for the installer isn't - doesn't recognize when the war has changed
20:16	pdurbin	Should we have a `mvn makeinstaller` that makes the installer? I mean... should the installer be made by mvn rather than make?
20:17	pameyer	maybe - not sure if it's worth the effort though
20:18	pdurbin	I don't think so.
20:21	pameyer	me either
20:22	pdurbin	pameyer: Leonid is the one who would care but he's on vacation for two weeks.
20:22	pameyer	it'll keep then
20:22	pdurbin	yeah
20:22	pdurbin	Please don't expect a response on the pull request until he gets back.
20:23	pameyer	ok - does that translate to "pull it back out of code review"?
20:24	pdurbin	nah, let's see what happens
20:24	pdurbin	I did just leave a review though.
20:24	pdurbin	hope it helps
20:25	pameyer	I've vaguely surprised that the coverage percentage changed when I didn't change any code or tests
20:27	pdurbin	hmm
20:54		jri joined #dataverse
22:55		jri joined #dataverse

Connect via chat.dataverse.org to discuss Dataverse (dataverse.org, an open source web application for sharing, citing, analyzing, and preserving research data) with users and developers.