Time
S
Nick
Message
05:52 bjonnh joined #dataverse
08:01 jri joined #dataverse
11:03 ruben48 joined #dataverse
11:52 pdurbin joined #dataverse
13:10 ruben48
pdubrin: I want to make a PR from this branch: https://github.com/uit-no/dataverse/tree/4334-oauth-dataporten
13:11 ruben48
but I don't know how to get the commits from kcondon removed as you liked to have it
13:13 ruben48
pdurbin *
13:15 pdurbin
ruben48: I should probably work off of a fork so that I better understand what contributors like you are going through. Generally speaking, you want to keep your local git repo up to date with "upstream" so that you can create pull requests with just a single commit.
13:16 pdurbin
I assume when you clone, you do `git clone git
13:17 pdurbin
Is that right, ruben48 ?
13:25 pdurbin
In your clone you can also look at .git/config
13:25 ruben48
think I got it.. need to play around some more in Git.. I have uesd git for a long time, but only in a very simple way with only 2 developers on one repo
13:25 pdurbin
Sure. This is a bit more complicated.
13:26 pdurbin
I think you're going to want a second remote, for "upstream" or whatever you want to call it.
13:26 pdurbin
When you sit down to fix a bug or whatever, you're going to want to fetch from upstream and branch from the latest in the "develop" branch of upstream.
13:27 pdurbin
That way, when you make a pull request, you'll only see your one commit. Or multiple commits you made, we don't care.
13:27 pdurbin
I hope this is making sense. Git is complicated.
13:33 pdurbin
I'm probably the one who cares the most about git history and we'd probably merge pull requests from you even if we see those commits from kcondon in there, but it's probably good for you to get comfortable with this stuff for other projects that are pickier about pull requests.
13:34 pdurbin
The Linux kernel is pretty picky about how to contribute. :)
13:52 ruben48
finally got it right
13:53 ruben48
just going to test it before making i PR, then you have someting to discuss over there :)
13:59 ruben48
there is someting dough.. seems like the username that I put into ParsedUserResponse don't show up in the "Username" field in the Create Account schema that pops up after authentication
14:00 ruben48
the same applies for GitHub
14:00 ruben48
authentication
15:07 pdurbin
ruben48: I'm seeing "Don't suggest a username. Fixed in f9cde16" at https://github.com/IQSS/dataverse/issues/3338 . Maybe this was a design decision? That commit says "for consistency with (local) sign up, don't suggest username".
15:11 pameyer joined #dataverse
15:14 pameyer
ruben48: my primary dataverse repo has three origins; my fork, and two for iqss dataverse (ssh and https) - https as the default so I don't push to it accidentally
15:26 pdurbin
ruben48: I'm sure that design decision can be revisited. Are you interested in fixing it?
15:28 pdurbin
pameyer: how much do you know about this `oauth2tokendata` table?
15:29 pameyer
pdurbin: not a tremendous amount
15:30 pdurbin
Ok. I mean, we didn't need it before. Now that the table exists, Google users see "Internal Server Error" when they create an account. Maybe I should simply not persist anything to that table for non-ORCID auth providers.
15:32 pameyer
are you still thinking their scope is longer than the table supports?
15:33 pdurbin
that's what ruben48 suspects and posted at https://github.com/IQSS/dataverse/issues/4337#issuecomment-348927604 (thanks!)
15:37 pameyer
I'd lean towards not storing potentially sensitive info that isn't used later; so it seems reasonable to not store it for google users
15:37 pdurbin
But we need it for ORCID, right? That table was added for a reason.
15:39 pameyer
yes, but depending on the value of "need"
15:39 pameyer
it's in the ORCID requirements, but isn't something that's later used
15:43 pdurbin
pameyer: can you please link me to where it says it's needed in the ORCID requirements?
15:44 pameyer
the same link as is in the ORCID 2.0 issue
15:45 pdurbin
Let me go find it.
15:45 pdurbin
One of the links in https://github.com/IQSS/dataverse/issues/4218
15:46 pdurbin
https://members.orcid.org/api/news/xsd-20-update says "Store full responses from token exchange: access tokens, refresh tokens, scope, scope expiry to indicate an iD has been authenticated and with what scope"
15:46 pdurbin
Store for how long?
15:46 pdurbin
Forever?
15:47 pameyer
I didn't see duration anywhere in the requirements
15:47 pameyer
not sure if mbs idd
15:47 pameyer
s/idd/did/g
15:48 pdurbin
ok, thanks
17:12 pameyer joined #dataverse
17:16 Thalia_UM joined #dataverse
17:16 Thalia_UM
Hello :)
17:16 Thalia_UM
Good morning !
17:17 pdurbin
how's it going, Thalia_UM ?
17:19 Thalia_UM
I still try to modify the code to put the web services when creating a dataset
17:20 pdurbin
Thalia_UM: right, and you created an issue, didn't you. Let me go look for it.
17:21 Thalia_UM
My team told me to do it with Jquery and I can request the data, but I don't know how to put them in the interface
17:21 Thalia_UM
Yes
17:21 pdurbin
Here it is: https://github.com/IQSS/dataverse/issues/4282
17:21 Thalia_UM
Philip what is the page to share image ??
17:22 pdurbin
I often use https://imgur.com
17:22 pdurbin
Thalia_UM: but you can attach images to that GitHub issue you opened.
17:22 pdurbin
screenshots often help clarify GitHub issues
17:22 Thalia_UM
Ok
17:27 Thalia_UM
How do I add the image?
17:28 pdurbin
Thalia_UM: you can leave a comment to the issue and click where it says "attach files".
17:32 jri joined #dataverse
17:36 Thalia_UM
I can't comment
17:38 Thalia_UM
This is the image
17:38 Thalia_UM
https://imgur.com/o3a2Qr7
17:38 pdurbin
You can't comment on 4282?
17:39 Thalia_UM
No
17:40 pdurbin
Are you logged in to GitHub?
17:44 Thalia_UM
Yes
17:45 pdurbin
Thalia_UM: I just invited you to join https://github.com/orgs/IQSS/teams/dataverse-readonly/members
17:45 pdurbin
Can you please accept the invitation?
17:46 Thalia_UM
04
17:46 Thalia_UM
404
17:46 Thalia_UM
Yes but the page is 404
17:46 pdurbin
Hmm. Did you get an email?
17:47 Thalia_UM
Yes
17:47 Thalia_UM
Your browser did something unexpected. Please contact us if the problem persists.
17:47 Thalia_UM
That is the message at the page
17:48 pdurbin
Can you please try a different browser?
17:50 Thalia_UM
Ready
17:50 Thalia_UM
yes
17:50 Thalia_UM
:)
17:50 pdurbin
You were able to accept the invitation?
17:50 Thalia_UM
yes
17:50 pdurbin
Great! Can you comment on the issue now?
17:52 Thalia_UM
yes
17:52 Thalia_UM
:-[
17:52 pdurbin
great
18:02 Thalia_UM
How about my comment?
18:03 pdurbin
I'm asking in Slack if anyone can help.
18:03 Thalia_UM
Oh thank you Philip
18:04 pdurbin
Are you interested in calling in to the community call tomorrow? https://dataverse.org/community-calls
18:11 pameyer
Thalia_UM: how variable are your inputs? will they be different for different datasets, and if so what arguments will the external webservice handle?
18:12 Thalia_UM
I don't understand the question
18:12 pameyer
possibly also related - will the dataverse fields be free text (and not controlled vocab / checkbox / etc)?
18:12 pameyer
ok - will attempt to rephrase
18:14 pameyer
create dataset page -> call webservice( $maybe_some_arguments) -> values back from webservice to autofill (always the same | depend on arguments)
18:14 pameyer
does that help, or is it more confusing?
18:14 Thalia_UM
But i am trying expose the list of values of web services and replace the values at dataverse when i add a dataset, using Jquery.
18:15 pameyer
which values?
18:15 Thalia_UM
yes, that helps me
18:16 pameyer
or at least, an example of one you're thinking of?
18:16 Thalia_UM
for example that is URL of one web service
18:16 Thalia_UM
http://catalogs.repositorionacionalcti.mx/webresources/areacono
18:17 pameyer
where on the dataset page would that go into?
18:17 Thalia_UM
https://github.com/IQSS/dataverse/issues/4282 here there is a image
18:18 Thalia_UM
but i need that show the checkbox in the list
18:19 pameyer
"subject" field in dataverse?
18:22 Thalia_UM
yes
18:24 pameyer
ok - I *think* I understand what you're trying to do now, or almost
18:25 pameyer
are you thinking that the list of subjects will be checked/prechecked by the web service based on $something when the dataset is created?
18:25 pameyer
or that the list itself will be from the web service?
18:26 Thalia_UM
I am consuming the web service with Jquery
18:27 Thalia_UM
The list of values is fine, what does not appear, is the box of checkbox
18:28 Thalia_UM
I do not know how to fit it in the XHTML files
18:28 pameyer
is the list of values in your image coming from your web service, or the database/tsv file?
18:29 Thalia_UM
because my team does not want development, only with JQuery, javascript
18:29 Thalia_UM
Web service
18:31 pameyer
ok - I *think* I understand now
18:32 Thalia_UM
Great :)
18:32 Thalia_UM
Can you help me??
18:33 pameyer
I'm not completely sure, but I think this approach will break down later. Dataverse assumes that the list of subjects is from a pre-existing list in its database (what it refers to as a controlled vocabulary). if the web service is providing values that aren't in that database, it'll probably cause errors at a later stage.
18:34 pameyer
it might be possible to add to the list of subjects in the database (aka - provide all subjects from your web service to dataverse beforehand), and then just have the ajax calls pre-select them; but I'm not sure if that approach matches what you're trying to do
18:35 pameyer
you'd need to change one of the TSV files in dataverse; which I wouldn't consider development (but I'd consider jquery / ajax / etc development, so take that for what it's worth ;) )
18:37 pameyer
does that make sense?
18:39 Thalia_UM
yes, in fact I was thinking about that, but web services must be consumed in real time, that's why I did not store it in the database anymore.
18:42 pameyer
is the list of all possible subjects something that changes dynamically?
18:42 pameyer
changes in real time?
18:42 soU joined #dataverse
18:45 Thalia_UM
Yes
18:46 pameyer
do you have flexibility about the field in dataverse? I'm wondering if it can be something other than "subject"
18:47 pameyer
aka - create a "Thalia_UMs_subject" free-text field, and put the values from your webservice there
18:49 Thalia_UM
I still do not know how to handle XHTML and JSF
18:53 pameyer
I could be wrong, but if you need to use dataverse's built-in "subject" I don't think XHTML /JSF changes will be enough
18:54 pameyer
in other words, the backend problems would occur regardless of how those worked. but again; I could be wrong about that
18:56 pameyer
if you can use a "custom_subject" (which doesn't have to be displayed with that name), then it probably does not need XHTML /JSF changes - AJAX replacement of innerHTML on the element should be enough
18:56 Thalia_UM
I'm also thinking about that, in fact I reviewed a little JSF and there are many related files
19:29 pdurbin
soU: I mentioned your upgrade in the community news: https://groups.google.com/d/msg/dataverse-community/71iqlFjftS4/RJXAes89AAAJ
22:03 jri joined #dataverse
