Time
S
Nick
Message
08:25 jri joined #dataverse
08:30 jri joined #dataverse
09:00 jri_ joined #dataverse
09:22 soU joined #dataverse
09:56 jri joined #dataverse
10:28 jri_ joined #dataverse
11:09 jri joined #dataverse
11:27 soU joined #dataverse
12:05 soU
Hi pdurbin: sorry i was a bit busy yesterday. Could you assign me for #4431, hopefully i'll send a pull request today
12:38 pdurbin
soU: thanks! Assigned!
12:42 soU
thanks pdurbin: pull request has been made on dev branch
12:42 pdurbin
that was quick!
12:51 pdurbin
soU: I just left a review
12:56 soU
ok will check it, thanks
12:57 pdurbin
overall, looks great, thank you very much!
13:00 soU
my pleasure! will make the changes
13:01 pdurbin
great
13:04 pdurbin
soU: another thought. You could edit the text under :ApiTermsOfUse at installation/config.rst to explain where API users can read the API Terms of Use. You just added a second place.
13:13 soU
I was adding this "Get API Terms of Use. The response contains the text value inserted as API Terms of use which used the database setting ``:ApiTermsOfUse``:" you want me to add more detail?
13:14 soU
or change the wording?
13:16 soU
pdurbin:what do you think?
13:21 pdurbin
soU: that sounds great. I was trying to say that there is a page in the Installation Guide you could edit as well.
13:22 pdurbin
This text: http://guides.dataverse.org/en/4.8.5/installation/config.html#apitermsofuse
13:24 pdurbin
If you want you could add something like "API users can retrieve this URL from the SWORD Service Document or the "info" endpoint of the Native API.
13:34 soU
great, will edit the guide text too
13:49 soU joined #dataverse
14:32 soU
pdurbin: please check the amendments
15:28 pameyer joined #dataverse
15:39 pdurbin
soU: looks great. I just fixed a typo.
15:39 pdurbin
We have standup in about half an hour. I'll mention your pull request and ask if anyone else wants to take a look before we move it to QA.
15:40 soU
Thanks
15:41 pdurbin
Are there any other bugs you want to work on? :)
15:44 soU
When i got one, will come back :)
15:44 pdurbin
sounds good :)
16:05 pdurbin
soU: please don't forget to leave a comment on https://github.com/IQSS/dataverse/issues/2911 about how you are affected by that issue.
16:07 pdurbin
That reminds me. Did everyone see "Dataverse New Year Survey: Help us prioritize development for 2018!"? The deadline to respond is Monday. Everyone here is welcome to fill out that survey which gives you the opporunity to vote for issues you'd like to see fixed: https://groups.google.com/d/msg/dataverse-community/HMsy1t4BVT4/yGb-HFxgAgAJ
16:08 pdurbin
andrewSC bjonnh bret jhand JonathanNeal jri knikolla pameyer soU yoh ^^
16:08 pameyer
pdurbin: my "other comment" was "ignore if this is the 2nd time I did it"
16:10 pdurbin
heh, I think I'm going to not bias the survey by filling it out. I'll leave it to the community
16:10 pameyer
pdurbin: InfoIT wasn't on my list
16:10 pdurbin
if that wasn't clear I mean I'm planning on declining to fill out the survey. I'll let real users fill it out.
16:12 pameyer
and I haven't gotten my wildcard/exclude pattern working yet
16:12 pdurbin
pattern for what?
16:13 pameyer
integration tests
16:13 pdurbin
oh, duh
16:18 pameyer
is there a source of truth for which ones are expected to pass?
16:27 pdurbin
pameyer: I consider the "phoenix" server to be the source of truth for which tests are passing and failing: http://guides.dataverse.org/en/4.8.5/developers/testing.html#the-phoenix-server
16:28 pameyer
weird - private URL looks failing there, but looks ok on my end
16:29 pameyer
and sorry; you've probably told me that about phoenix before
16:29 pdurbin
no worries
16:29 pdurbin
I can kick off another build. I thought I had eliminated most of the "flake" in these tests but sometimes they do fail for mysterious reasons.
16:30 pdurbin
pameyer: if they still fail after another build, would you mind opening a github issue?
16:31 * pdurbin
clicks "Build Now"
16:31 pameyer
pdurbin: when I run it, it looks like it passes.
16:31 pameyer
if you're in there, do you have a URL for the list on jenkins?
16:34 pdurbin
pameyer: it's here but I don't think "configure" is public: https://build.hmdc.harvard.edu:8443/job/phoenix.dataverse.org-apitest-develop/configure
16:34 pameyer
looks like it's not
16:38 pameyer
and InfoIT is reproducibly failing for me (aka - it's not fiddliness with my environment this time)
16:42 pdurbin
gotcha. well, InfoIT isn't being tested by that phoenix server
16:42 pdurbin
Here's the current list: mvn test -Dtest=DataversesIT,DatasetsIT,SwordIT,AdminIT,BuiltinUsersIT,UsersIT,UtilIT,ConfirmEmailIT,FileMetadataIT,FilesIT,SearchIT,InReviewWorkflowIT -Ddataverse.test.baseurl='http://phoenix.dataverse.org '
16:43 pameyer
pdurbin: thanks - looks like I was missing a few (InReview, Search)
16:43 pameyer
in addition to InfoIT, of course
16:43 pdurbin
pameyer: I'm going to consider this out of scope though. I just move soU 's pull request to QA. He wrote some tests, which is great, and we can clean them up later. It wouldn't suprise me if InfoIT was failing before he touched it.
16:43 pameyer
good point - that I didn't check
16:43 pdurbin
it's not worth checking
16:44 pdurbin
the source of truth doesn't check it
16:44 pdurbin
probably it should some day
16:44 pdurbin
somebody could create an issue. should be low hanging fruit. maybe hackathon territory
16:46 pdurbin
pameyer: the latest build (163) is now passing: https://build.hmdc.harvard.edu:8443/job/phoenix.dataverse.org-apitest-develop/ . Phew. :)
16:47 pameyer
yeah - if it passed for me, and didn't work there I'd be really confused
16:51 pdurbin
I'm glad the test suite is passing for you too.
16:51 pameyer
DataversesIT,DatasetsIT,SwordIT,AdminIT,BuiltinUsersIT,UsersIT,UtilIT,ConfirmEmailIT,FileMetadataIT are passing for me, at least
16:52 pameyer
… but back to ddi for me
16:52 pdurbin
cool, we need to get that exclude working :)
16:53 pdurbin
yeah, lemme know if I can unblock you on the ddi import stuff. it's been a while but I did write that roundtrip ddi thing
16:54 pameyer
btw - since I switched to a tmux session that I'd been working on the wildcard/exclude, it looks like InfoIT was working as of a few days back
16:55 pdurbin
gotcha
17:27 Alejandra82 joined #dataverse
17:27 Alejandra82 left #dataverse
17:28 Alejandra44 joined #dataverse
17:29 Alejandra44
Hello
17:29 Alejandra44
Regards!
17:29 pdurbin
Alejandra44: hi!
17:30 Alejandra44
One question
17:30 Alejandra44
Can I set up Dataverse to use LDAP?
17:31 Alejandra44
we want to authenticate users with Active Directory
17:42 pdurbin
Alejandra44: I think the only way is via ORCID
17:43 pdurbin
Alejandra44: please see "LDAP support via ORCID" at https://groups.google.com/d/msg/dataverse-community/iq2KHLsz5ZA/6t08gJq5BQAJ
17:43 pdurbin
but! let us know if you'd like to make a pull request :)
17:44 jri_ joined #dataverse
17:47 Alejandra44
jejeejeje ok, thank you, i'm going to read the forum
18:19 pameyer
huh - I hadn't known about LDAP via ORCID
18:40 pdurbin
pameyer: you should read all my posts to the google group. ;) I'm up to 772 posts. :)
18:42 pameyer
it's vaguely surprising I didn't notice anything about LDAP when I was reading up on the 1.2 to 2.0/2.1 ORCID changes
18:43 pameyer
but I wasn't looking for it, I guess
18:48 pdurbin
it's just something I noticed. the ORCID login UI keeps changing. LDAP wasn't there the first time I looked at it
18:48 pdurbin
pameyer: I just noticed the wildcard issue you made. Thanks. https://github.com/IQSS/dataverse/issues/4438
18:49 pameyer
pdurbin: incremental steps
18:50 pdurbin
yeah, I punted on figuring that out years ago
18:50 pameyer
I *think* the annotation would do it
18:51 pameyer
but then it would need code changes if somebody wanted to do something like run the S3 tests
18:53 pdurbin
Can we check the list into the code and somehow have Jenkins operate on the list? It would need to go in the "Goals and options" box under "Build" in Jenkins.
18:55 pameyer
it could go into a `Jenkinsfile`; but that might mean redoing the existing pipeline
18:57 pdurbin
hmm
18:57 pdurbin
I'm not sure how to go from what we've got to a Jenkinsfile.
18:58 pameyer
me either :(
21:16 pdurbin
pameyer: what if we used Jenkins within openshift/minishift: https://docs.openshift.org/latest/install_config/configuring_pipeline_execution.html ? Would that get us a step closer?
21:32 pdurbin
I'll try to talk more about it when you're here. Anyway, I gotta run. Have a great weekend, everybody. Pease don't forget to fill out that survey. It's due Monday. ^^
21:32 pdurbin left #dataverse
22:10 pameyer
pdurbin: possibly - but yeah, let's talk more next week. I think if you've got (or can get) the jenkins CLI working that'll help with jenkins openshift/minishift and list of tests
