Time
S
Nick
Message
01:17 jri joined #dataverse
04:17 jri joined #dataverse
07:06 juancorr joined #dataverse
07:07 jri joined #dataverse
08:22 cdsp-rmo
pdurbin: nope, I didn't touch this (translation)
08:53 juancorr
pdurbin: I had replied the e-mail at https://github.com/IQSS/dataverse/issues/4842#issuecomment-429896821 and the comment lost the screenshots. I have added a new comment
10:10 jri_ joined #dataverse
10:10 pdurbin
cdsp-rmo: ok, thanks
10:11 pdurbin
juancorr: thanks for adding the screenshots
11:09 donsizemore joined #dataverse
12:09 donsizemore joined #dataverse
12:12 poikilotherm joined #dataverse
13:30 pdurbin
Jim_: my question is about "county" at https://github.com/IQSS/dataverse/blob/v4.9.4/src/main/java/edu/harvard/iq/dataverse/DatasetVersion.java#L865-L871
13:45 Jim_
OK - what looks wrong?
13:47 pdurbin
The isEmptyForDisplay logic is different than the ones below for state, city, etc.
13:52 Jim_
Ah -you're probably right. I think most of what I did was to move existing methods between classes - let me see if I can see where it came from and make sure there's no reason there.
13:53 pdurbin
Jim_: that's what I figured, that it wasn't your original code, but you touched it last. What would the bug be? That countries don't appear in citations? I didn't know that countries even could appear in citations? I say this because the method is called from DataCitation.java.
13:59 Jim_
Looks like I made this :-) DataCitation is now the class the generates all the bibtex, ris,endnote downloads and one or more of those should now include the geospatial coverage.
13:59 Jim_
And yes - I think it just makes country not appear.
13:59 Jim_
when it should
14:00 pdurbin
ok, thanks
14:00 Jim_
thank you - another fine catch!
14:00 pdurbin
I thought I smelled a bug. Thanks for confirming.
14:01 Jim_
parallel construction - learned it in english!
14:01 pdurbin
:)
14:01 Jim_
Or maybe it was one of these things is not like the others from sesame street
14:01 pdurbin
The reason I bring it up is that I wrote a second method without the bug. Once sec.
14:01 pdurbin
One*
14:03 pdurbin
Oh, and the method I wrote doesn't add commas.
14:03 pdurbin
So I added a TODO to consider switching to the new method. In this commit: https://github.com/IQSS/dataverse/commit/a84f1d1 . But this code is still in flux so maybe we should fix the country bug separately. I just wanted to put all this on your radar.
14:04 pdurbin
Because I'm sure you don't have enough to worry about already. :)
14:08 Jim_
I'd say go ahead and flip to use your new method now - no reason to have both around.
14:09 Jim_
(and "," should probably be ", " anyway - I'm guessing a similar issue where a join is adding ";" rather than "; " is the root of the author citation issue that's been reported.
14:10 pdurbin
Nah, I'm going to keep with our "small chunks" philosophy. I'll just leave the TODO in there. Maybe I'll add another comment about the suspected bug.
14:16 Jim_
OK - I'll try to remember to submit a fix at some point. BTW - is it OK that your method flattens things, e.g. a city name is added to the big list without being associated with a state (which could cause confusion)
14:17 Jim_
versus a list of lists to turn into json...
14:18 pdurbin
The thing is that Julian and I are trying to figure out how to implement spatialCoverage in Schema.org JSON -LD. He doesn't particularly like the way ICPSR does it, which influenced my commit above.
14:20 Jim_
I haven't looked at the outputs but since there can be multiple coverages, each with country/state/city components, it seems like preserving that hierarchy would be important...
14:22 Jim_
(Could compare with how it shows up in the new oremap json-ld export... that just does a big loop through all compound fields.)
14:26 pdurbin
If you "view source" and look for ld+json you can see how spatialCoverage is implemented: https://www.icpsr.umich.edu/icpsrweb/ICPSR/studies/23980/export
14:32 Jim_
yeah - theirs doesn't tell you whether it is Boston, MA or Boston, FL (assuming there is one).
14:36 Jim_
The OAI-ORE exporter creates an array of objects, one per coverage, that have key/value pairs for country, state, city, other...
14:36 pdurbin
sounds better
14:39 donsiemore joined #dataverse
14:39 Jim_
probably all depends on what google will parse
14:40 Jim_
poikilotherm leaving made me remember something - I was going to ask here if anyone else has seen/understands log errors that I think recently appeared:
14:40 Jim_
Exception while visiting META-INF/versions/9/org/junit/platform/commons/util/ModuleUtils.class of size 10770 java.lang.IllegalArgumentException
14:41 Jim_
My guess from googling was the newer junit lib being compiled with newer java that glassfish doesn't handle well.
14:41 Jim_
Seems non-fatal, but not my area ...
14:42 pdurbin
Is this extra logging in a release? Or just in the develop branch?
14:42 Jim_
should be 4.9.4
14:45 pdurbin
bleh
14:56 isullivan joined #dataverse
14:56 juancorr joined #dataverse
15:31 isullivan joined #dataverse
17:00 jri joined #dataverse
17:43 donsizemore joined #dataverse
17:53 pameyer joined #dataverse
18:17 pameyer
it seemed vaguely surprising to me that junit anything would be ending up in the war file
18:22 pdurbin
good point
18:23 pdurbin
pameyer: If I edit scripts/installer/install should I expect the changes to be reflected immediately when I run ./conf/docker-aio/prep_it.bash ?
18:27 pameyer
pdurbin: presumably - prep_it should rebuild the image and restart the container
18:27 pameyer
ah - but prep_it doesn't use the standard dataverse installer; so you won't see the new admin password there
18:28 pdurbin
What does it use instead?
18:30 pameyer
setupIT.bash - which is basicly using the phoenix scripts
18:30 pameyer
I think the only difference is that it doesn't attempt to do schemaspy
18:32 pdurbin
Ah, and you have a "post". Perfect.
18:40 julian joined #dataverse
18:41 Guest2583
Hi cdsp-rmo! Are you there?
18:51 pdurbin
hi Guest2583
18:52 pdurbin
pameyer: ok, I made a pull request and linked it from https://github.com/IQSS/dataverse/issues/4178#issuecomment-430354970
18:52 pameyer
pdurbin: Guest2583 is also known as julian
18:52 pameyer
I saw the PR, taking a look at it now
18:52 pameyer
slightly confused
18:53 pdurbin
that's normal :)
18:53 pameyer
it is :)
18:54 pameyer
is that one a replacement for 5182, or a supplement?
18:55 pdurbin
replacement. different approach
18:55 pameyer
haven't kicked the tires yet, but I think it misses the use case I was shooting for
18:56 pameyer
variable in setup-all is less of a hack than search and replace; but only handles setupIT cases
18:59 pdurbin
Yeah, the search and replace was bothering me. What are the other cases you're thinking about?
18:59 pameyer
using the normal installer
19:00 pameyer
the case where I ran into it most recently was another "coming up with custom metadata" things
19:00 pdurbin
Ok, but docker-aio doesn't use the normal installer, does it?
19:01 pameyer
it has the option to use both. prep_it uses setupIT, because it seemed like that's what most folks would be using it for
19:01 pdurbin
Ah, cool. I've never used the other mode.
19:02 pameyer
right - you use local glassfish/postgres/solr for dev
19:02 pameyer
docker-dcm uses the normal installer in docker-aio, for what that's worth
19:07 Guest2583 left #dataverse
19:07 julian joined #dataverse
19:08 Guest74228 left #dataverse
19:08 juliang joined #dataverse
21:28 donsiemore joined #dataverse
21:34 jri joined #dataverse
