Time
S
Nick
Message
00:34 sivoais joined #dataverse
07:36 jri joined #dataverse
09:54 thanh-thanh joined #dataverse
09:55 thanh-thanh
Hello Dataverse team !
09:55 thanh-thanh
I opened up 1 discussion yesterday in the Dataverse community
09:55 thanh-thanh
https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/dataverse-community/hehhGrHtUDk/_-chHU8tAwAJ
09:56 thanh-thanh
asking about License management feature that we consider to develop and contribute to dataverse
09:58 thanh-thanh
can you please tell us, if whether the feature interests you guys, to integrate it into dataverse if we develop it? And then, mandatory criteria so that the development can be accepted and integrated into dataverse project ?
09:58 thanh-thanh
Thank you very much
09:58 thanh-thanh
and if this is not the right place to ask, please kindly tell me how to obtain the reponse to my questions :)
10:40 poikilotherm joined #dataverse
10:42 pdurbin
whoops, missed her
10:42 poikilotherm
Morning pdurbin
10:42 pdurbin
mornin
10:42 poikilotherm
I was about to write that you should be with us any minute :-D
10:42 pdurbin
:)
10:42 poikilotherm
Then I saw that they is not with us anymore
10:43 pdurbin
it's a nice place to be :)
10:43 poikilotherm
Sure :-)
10:43 poikilotherm
I invited Slava, too
10:44 poikilotherm
And his colleague... Err... I think Wilko was his name
10:44 pdurbin
something like that
10:45 poikilotherm
pdurbin there is an initiative to create a Dataverse DE/NL meeting on 3rd of June
10:45 poikilotherm
Stuttgart is trying to get people from Göttingen, Heidelberg, Cologne, Berlin and Jülich together
10:45 pdurbin
nice!
10:46 poikilotherm
And they invited DANS/CESSDA/DataverseEU, too.
10:48 pdurbin
you're gonna need a bigger boat :)
10:53 pdurbin
poikilotherm: oh, speaking of this channel, wanna see the plot I was hacking on last night?
10:54 poikilotherm
Sure :-)
10:54 pdurbin
https://i.imgur.com/93dkJyg.png
10:54 pdurbin
what do you think? :)
10:57 poikilotherm
Missing a title :-D
10:58 poikilotherm
Maybe have a better starting on the X axis would be good
10:58 poikilotherm
is this 2013?
10:58 poikilotherm
Oh and why are the bars for december halfway into the next year?
10:58 poikilotherm
I know, just small issues :-D
10:58 pdurbin
because I'm new to the tidyverse :)
10:59 poikilotherm
Overall pretty cool!
10:59 poikilotherm
Impressing
10:59 pdurbin
my plan is to make this into a jupyter notebook and launch it from Dataverse
10:59 poikilotherm
Could you add a mapping? Using stacked bars to show messages by IQSS members and community members?
11:00 poikilotherm
Sounds cool!
11:00 pdurbin
it's mostly community members
11:00 poikilotherm
One day I will find some time to play with Jupyter, too ;-)
11:00 poikilotherm
This could be an interesting message: look, here is where THE COMMUNITY is talking.
11:01 pdurbin
:)
11:02 pdurbin
I'll probably put it on github first, actually, I sort of already did.
11:02 pdurbin
a long time ago a friend made this for me: https://github.com/willingc/irc-pdurbin ... to get me started
11:03 poikilotherm
I would like to see it overlayed with a plot of commits to dataverse in the same period
11:03 poikilotherm
Does this correlate?
11:03 pdurbin
and the other day I got it working on python 3 and added it to https://github.com/IQSS/chat.dataverse.org/blob/904e5bb315cfea799d6d2b1677ee6a0cd30b6de2/metrics/irc-metrics.ipynb
11:04 pdurbin
but the problem is that the python version is really just a stub, and I don't now pandas
11:04 pdurbin
so I went to the data science consultants here and they told me I should use R instead, dplyr specifically
11:04 poikilotherm
:-)
11:04 pdurbin
so I switched
11:05 pdurbin
so I guess I'll update the notebook in that repo
11:05 poikilotherm
Great :-)
11:05 pdurbin
or I was thinking maybe it should go in a different repo since that chat repo is mostly just config for the chat service
11:05 poikilotherm
Wouldn't it make sense to add it to metrics?
11:06 poikilotherm
Its an important part of dataverse
11:07 stefankasberger joined #dataverse
11:07 pdurbin
add it to https://github.com/IQSS/dataverse-metrics you mean?
11:07 poikilotherm
Yeah
11:08 pdurbin
maybe, on a related note there's a new "Show Github contribution metrics" issue: https://github.com/IQSS/dataverse-metrics/issues/16
11:08 poikilotherm
Hey stefankasberger, did the invitiation from Dorothea Iglezakis reach you?
11:09 poikilotherm
pdurbin: yes! Great!
11:09 poikilotherm
I really think this stuff is important to show
11:09 poikilotherm
You are lucky you such a community and it might other inspire to jjoin
11:09 poikilotherm
+have
11:09 poikilotherm
Whoops
11:09 poikilotherm
That sentence was a mess
11:10 poikilotherm
You are lucky to have such a vibrant community and it might inspire others to join
11:10 pdurbin
:)
11:11 pdurbin
community building is like gardening
11:11 poikilotherm
Sounds like you have a great and big garden with many beautiful flowers at home :-D
11:12 pdurbin
some day, after we move to the new house :)
11:12 poikilotherm
*thumbs up*
11:13 pdurbin
stefankasberger: hi! Did my issue at https://github.com/AUSSDA/pyDataverse/issues/5 make sense? :)
11:15 pdurbin
poikilotherm: I'll probably put the jupyter notebook in github first and launch it from https://mybinder.org . I forget if you've seen the "binderverse" issue. :)
11:16 pdurbin
this will force me to use their folder structure
11:16 pdurbin
and ensure that it launches properly
11:16 pdurbin
then I'll download the git repo as a zip and put it in Dataverse
11:17 pdurbin
preserving the folder structure
11:17 pdurbin
then try to launch it in whole tale
11:19 poikilotherm
Sounds like you're "the man with plan"
11:19 poikilotherm
:-)
11:19 poikilotherm
BTW https://github.com/IQSS/dataverse/issues/5293#issuecomment-493418542
11:20 poikilotherm
It would be such a pleasant thing to switch to Payara 5 and refactor settings...
11:21 pdurbin
I know. How can we prioritize it?
11:22 poikilotherm
Dunno. Will send Slava the issues about the transition
11:22 poikilotherm
He said sth. about trying to get some funding for this
11:22 poikilotherm
Dunno what he is up to, but if there is a chance for this it would be a great thing
11:22 poikilotherm
IMHO
11:23 pdurbin
he's always up to great stuff
11:24 poikilotherm
LOL
11:24 poikilotherm
WTF
11:24 poikilotherm
#4248 got a label "too large to estimate"
11:25 poikilotherm
This really sounds like a HUGE blocker
11:25 pdurbin
huh, 8 days ago
11:26 poikilotherm
Maybe one of the reasons this is a nut hard to crack is about having this in mind for a Dataverse 5.0
11:26 poikilotherm
And connected to Dataverse 5.0 are a lot of other good things like DataTags etc
11:27 poikilotherm
Maybe things could start moving by changing the roadmap to have a Dataverse 5.0 on Payara 5 and do other big stuff in later major/minor releases?
11:28 poikilotherm
I understand the implications of a switch to Payara 5 and it seems to be a good idea to make a Dataverse version 5.0 for it to indicate the major change.
11:29 poikilotherm
Actually for people using k8s images, this shouldn't make that much difference
11:29 poikilotherm
It obviously will be for manual installations
11:30 stefankasberger
@poikilotherm: Hi, no, did not see anything in my inbox -> stefan.kasberger
11:30 pdurbin
I don't think getting off ancient glassfish should be tied to Dataverse 5.
11:30 poikilotherm
@stefankasberger: she asked people to forward the invitation to people from CESSDA/DataverseEU/...
11:31 poikilotherm
Happy to forward :-)
11:31 stefankasberger
Please let her kwow, she should re-send it to me again, and i will do my best.
11:32 stefankasberger
@pdurbin: regarding issue#5: will add some information later on.
11:32 poikilotherm
@stefankasberger: check your mailbox :-D
11:32 poikilotherm
I don't think she has you mail adress :-D
11:32 poikilotherm
+r
11:33 pdurbin
stefankasberger: thanks!
11:42 stefankasberger
got it, thanks.
12:11 thanh-thanh joined #dataverse
12:15 thanh-thanh joined #dataverse
12:26 pdurbin
thanh-thanh: hi! I'm sorry I missed your messages earlier! Are you around?
12:26 thanh-thanh
yup, me herre
12:26 thanh-thanh
:)
12:26 thanh-thanh
just logged in
12:27 pdurbin
Ah, great. I did see that thread on the google group. Did you see that Merce replied?
12:27 thanh-thanh
yup, I've seen her reply
12:28 thanh-thanh
I'm about to reply to say that I've made a note about her good idea,
12:28 pdurbin
That's perfect. There are a few GitHub issues that show how much interest there is in this feature.
12:29 thanh-thanh
but before starting the development, we need more information in order to be sur that our dev will be integrated
12:29 thanh-thanh
:)
12:29 pdurbin
The oldest issue is probably https://github.com/IQSS/dataverse/issues/1753 and ther is some good discussion there and links to other issues.
12:30 pdurbin
thanh-thanh: yes, it's very important for development to be coordinated. I forget, have you or your developers made a pull request yet?
12:31 thanh-thanh
we didn't do anything up till now
12:31 thanh-thanh
in this project I mean,
12:31 thanh-thanh
this will be our first time contributing to dataverse
12:32 thanh-thanh
so, we reach out first to know exactly what and how to do
12:32 pdurbin
Ok, I wonder if it would be good to start with a small unrelated pull request so you understand our process. We'd love to get contributions from you!
12:34 pdurbin
I have a couple small issues in mind if you'd like to try working on one of them.
12:35 thanh-thanh
for this, I can not really answer to you directly unfortunately :(
12:35 thanh-thanh
we have in fact, our POs, who decide what to do
12:35 thanh-thanh
this feature is one of their story,
12:37 pdurbin
PO is product owner?
12:37 thanh-thanh
they want to be sure if we make an effort to do this, it will be integrated to dataverse
12:37 thanh-thanh
yes, sorry, PO = product owner
12:38 pdurbin
Sure, I understand completely. What I'm trying to say is that it would be great if we could test and merge a small change to the guides or the code first. I could point you to an existing issue or you could make one. The point is that it should be small. Hopefully only one line of code or docs.
12:38 pdurbin
Does that make sense?
12:39 pdurbin
actually, I can think of some typos, some misspellings in the guides... as an example :)
12:40 pdurbin
The goal would be for you to understand our process. With a small example. A typo fix.
12:40 thanh-thanh18 joined #dataverse
12:40 thanh-thanh18
hik , I was disconnected
12:40 thanh-thanh18
sorry
12:41 pdurbin
thanh-thanh18: no problem. It's not your fault. There's a memory leak in the web interface I installed for this chat room. :(
12:42 pdurbin
Can you please catch up on what I wrote at http://irclog.iq.harvard.edu/dataverse/2019-05-17#i_93974 ? :)
12:42 thanh-thanh18
yes
12:42 pdurbin
thanks!
12:42 thanh-thanh18
I've just finished reading it
12:42 thanh-thanh18
:)
12:42 pdurbin
in short, I'm suggesting that I could show you a typo in the guides and then you or your developer could make a pull request to fix it
12:42 pdurbin
just to understand our process
12:43 pdurbin
does that make sense?
12:43 thanh-thanh18
ok for me in fact,
12:44 thanh-thanh18
I will inform our Product Owner and my team in fact
12:45 thanh-thanh18
but if you have in mind now some small issue to choose
12:46 thanh-thanh18
I'll take note and discuss with them
12:46 pdurbin
great, please hold on I'm looking for the typo :)
12:46 thanh-thanh18
:)
12:46 pdurbin
found it
12:46 pdurbin
"identifiy" is misspelled at http://guides.dataverse.org/en/4.14/admin/dataverses-datasets.html#diagnose-constraint-violations-issues-in-datasets
12:46 thanh-thanh18
but we're agreed that the feature I've discribed is interesting for you ?
12:47 pdurbin
Merce agrees which is more important that me agreeing. :) But I very much agree too! :)
12:47 thanh-thanh18
:)
12:47 pdurbin
thanh-thanh18: can you please go ahead and create an issue for the "identifiy" typo?
12:48 thanh-thanh18
ah, oki
12:48 pdurbin
that will start the process
12:48 pdurbin
I'll assign the issue to you (since we already talked about it).
12:48 pdurbin
Then I'll move it to the "community dev" column on our kanban board.
12:49 pdurbin
Then you'll make the pull request (or ask someone else you work with to make the pull request).
12:53 donsizemore joined #dataverse
12:54 thanh-thanh18
https://github.com/IQSS/dataverse/issues/5855
12:54 thanh-thanh18
created, sorry, I need to reset my password :)
12:55 pdurbin
no problem. do you see it at the top of Community Dev at https://github.com/orgs/IQSS/projects/2 ? I assigned it to you. :)
12:55 thanh-thanh18
yes
12:56 poikilotherm
Sorry to interfere - pdurbin I refactored docs for https://github.com/IQSS/dataverse-kubernetes . You might give it a look and raise an issue if you find things unclear, wrong or suspicious... ;-)
12:56 poikilotherm
Have a nice weekend everybody
12:56 poikilotherm
Cu Monday
12:57 pdurbin
thanh-thanh18: are you going to be making the pull request? You might want to have the developer who's going to work on the license stuff do it. I don't know if that's you or not. :)
12:57 thanh-thanh18
I'm one of them lol
12:59 pdurbin
Ok, great. For this simple doc change you could probably just use the GitHub web interface but I think you should use the git command line or whatever gui git took you like.
12:59 pdurbin
You should make a branch called "5855-typo"
12:59 pdurbin
and then commit a fix to that branch
12:59 pdurbin
and then make a pull request
13:00 thanh-thanh18
oki, so, the rule is that we create the branch with issue number as the prefix
13:00 thanh-thanh18
and after that, make a pull request
13:00 pdurbin
yes
13:01 pdurbin
it's not a strict rule but it helps us stay organized :)
13:01 thanh-thanh18
I need to create the branch from the develop branch I suppose?
13:01 pdurbin
yes, that's right
13:02 thanh-thanh18
oki, for our feature, we'll need to create an issue, then you assign to someone of us, then dev, then pull request
13:02 thanh-thanh18
this is the general schema I suppose
13:03 pdurbin
yes, that's right but we should also have a meeting because it's a lot more work than fixing a typo :)
13:03 thanh-thanh18
yup sure
13:03 thanh-thanh18
:)
13:04 pdurbin
also, the design team has a new process for documenting the requirements first
13:04 pdurbin
"Design Project Template
13:04 thanh-thanh18
oki,
13:04 pdurbin
"Design Project Template: this document serves as a working doc and reference throughout the project, and as a record at the end of the project. At the beginning it serves as a questionnaire for a stakeholder kickoff, and then as a design brief for the team, outlining goals."
13:05 pdurbin
a brief paragraph statement of the problem from the user perspective.
13:05 pdurbin
list no more than 3 key metrics we will measure to show success, and the expected change
13:05 pdurbin
One, two, or more user types we are designing this particular functionality for. This is intended to capture user types by role, (curator, etc) and MAY include specific people if relevant/applicable/known.
13:05 pdurbin
etc
13:06 pdurbin
I'm not sure if it would be helpful for you to fill that out or not. I think we should have a meeting first. :)
13:07 thanh-thanh18
:)
13:08 pdurbin
Also, we like to work in "small chunks".
13:08 pdurbin
For this feature I can imagine these chunks:
13:08 pdurbin
- update the database schema to support the licenses we need
13:08 pdurbin
- create an API to allow the new license to be used (no GUI yet)
13:09 pdurbin
- create the GUI , with input from the design team
13:09 pdurbin
Does that make sense?
13:09 thanh-thanh18
about the design, our POs have something in mind
13:10 thanh-thanh18
I didn't put it in the discussion, because the image is in french
13:10 thanh-thanh18
:)
13:10 pdurbin
:)
13:10 thanh-thanh18
we didn't think of API
13:10 pdurbin
That's great but we need your POs and our design team to agree. :)
13:10 pdurbin
every feature of Dataverse should be available via API
13:10 thanh-thanh18
yup, so I'll tell them this
13:10 pdurbin
it makes integrations easier
13:11 thanh-thanh18
totally agree :)
13:11 thanh-thanh18
uhm, your design team speak english ?
13:11 thanh-thanh18
:)
13:11 pdurbin
yes, english :)
13:11 thanh-thanh18
lol, oki, we'll see how to do this
13:12 thanh-thanh18
in brief, I'll tell them :
13:12 pdurbin
it'll be fun :)
13:12 thanh-thanh18
as you suggested :
13:12 thanh-thanh18
3 different story to do in small chunks
13:13 pdurbin
right
13:13 thanh-thanh18
and for the UI, we need to have a discussion with your design team, right ?
13:13 pdurbin
yes
13:13 pdurbin
and for the database schema change, you need to talk to the dev team
13:14 thanh-thanh18
lol
13:14 pdurbin
:)
13:14 thanh-thanh18
this, we can manage this ourself,
13:14 thanh-thanh18
well, so, in any case, we need to discuss first
13:14 thanh-thanh18
lol
13:14 pdurbin
yes, please :)
13:15 thanh-thanh18
but I want to be clear for one thing :
13:15 pdurbin
I mean, you can send us a SQL script first. That's fine. Then we have something to discuss. :)
13:15 thanh-thanh18
i'm asking you now about this, but I do not really know when we can start the dev
13:16 pdurbin
no problem
13:18 thanh-thanh18
:)
13:18 thanh-thanh18
and another question please
13:19 thanh-thanh18
about the coding, you have specific criteria ?
13:19 pdurbin
we have a "coding style" page: http://guides.dataverse.org/en/4.14/developers/coding-style.html
13:19 thanh-thanh18
in term of coding style, tests, etc.
13:20 pdurbin
and a "testing" page: http://guides.dataverse.org/en/4.14/developers/testing.html
13:21 thanh-thanh18
thanks
13:21 thanh-thanh18
so, to resume
13:21 pdurbin
sure, this is a good starting point: https://github.com/IQSS/dataverse/blob/v4.14/CONTRIBUTING.md#codepull-requests
13:22 thanh-thanh18
I'll inform our POs like this
13:23 thanh-thanh18
the lisense management feature is interesting to you
13:23 thanh-thanh18
however, we need to split it into at least 3 issues to work with
13:24 thanh-thanh18
and we need to work with GUI team to have an agreement
13:24 thanh-thanh18
and the contribution will be done via pull request
13:24 pdurbin
Right. I don't know if you know Scholars Portal (they speak French) but they are working on a great new feature in small chunks. I can point you to their many issues and pull requests if you'd like an example.
13:24 thanh-thanh18
I miss someting ?
13:25 thanh-thanh18
It will be helpful
13:25 pdurbin
I think you missed one meeting.
13:25 thanh-thanh18
yes?
13:25 pdurbin
I would suggest creating one "umbrella" issue for now.
13:26 thanh-thanh18
umbrella ?
13:26 thanh-thanh18
sorry, do not understand :)
13:26 pdurbin
Hold on. Let me give you the Scholars Portal example.
13:26 pdurbin
Do your researchers ever upload CSV files to Dataverse?
13:26 thanh-thanh18
yes
13:27 pdurbin
And would they like a way to add descriptions for column names?
13:28 thanh-thanh18
hik, I do not have the answer on this
13:28 thanh-thanh18
@@
13:29 thanh-thanh18
It's our POs who have the direct interraction with them
13:29 pdurbin
Ok. Sometimes column names are very short. "asdf" or whatever. But "asdf" means something and researchers want to write down what "asdf" means. A description for each column.
13:30 pdurbin
In Data Explorer it would go in the "Label" field: https://scholarsportal.github.io/Dataverse-Data-Explorer/?fileId=3371438&siteUrl=https://dataverse.harvard.edu
13:30 pdurbin
Right now "Name" and "Label" are the same.
13:30 pdurbin
Scholars Portal is building a tool to let researchers edit the "Label".
13:30 pdurbin
I hope that makes sense. :)
13:31 pdurbin
They're calling the tool they're building "The Data Curation Tool" and here is the "umbrella" or "parent" issue: https://github.com/IQSS/dataverse/issues/4174 ... there are many "child" issues. Each child issue is a "small chunk" and has its own pull request.
13:32 thanh-thanh18
ah, oki
13:32 thanh-thanh18
thanks for explaination
13:33 pdurbin
It's a big feature. lubitchv (Victoria Lubitch) has made 4 pull requests that have been merged so far: https://github.com/IQSS/dataverse/pulls?q=is%3Apr+author%3Alubitchv+is%3Aclosed
13:33 pdurbin
and her latest pull request is in QA right now
13:33 pdurbin
So if you want, you could talk to Scholars Portal (probably in French) about their experience working with us.
13:34 pdurbin
But you don't have to, of course. :) You can just talk to us. :)
13:34 pdurbin
in English :)
13:34 thanh-thanh18
:D
13:35 pdurbin
A good time to talk is during a community call: https://dataverse.org/community-calls
13:35 pdurbin
but I'm sure it's too late in the evening for you :(
13:36 pdurbin
so maybe we could do a special community call at a time that's more convenient for you
13:37 thanh-thanh18
for the community-calls
13:38 thanh-thanh18
I'm not sure that we can make it
13:38 thanh-thanh18
:)
13:38 thanh-thanh18
how can we seak out an appointment ?
13:39 pdurbin
please email support
13:39 thanh-thanh18
:)
13:39 pdurbin
to schedule a meeting
13:40 thanh-thanh18
oki, that's good to know
13:40 pdurbin
that way it goes into our ticketing system and we can all see it
13:40 thanh-thanh18
I need to make a prefix or something relevent in the subject
13:40 thanh-thanh18
in order to have it quickly seen and treated ?
13:42 pdurbin
If you email that addresss I'll reply on the google group thread with a link to the support ticket that's created.
13:42 pdurbin
and a link to this conversation
13:42 pdurbin
so people can catch up
13:43 thanh-thanh18
ok, thanks you very much,
13:45 thanh-thanh18
I need to inform our POs all this
13:45 thanh-thanh18
and see with them on how to go with this
13:46 pdurbin
sounds great, and please don't forget to fix that typo :)
13:46 thanh-thanh18
I'll come back to you (in here I suppose) to keep you informed
13:46 pdurbin
sounds great :)
13:46 thanh-thanh18
lol, yes, I will not forget it :P
13:47 pdurbin
we can add you to the "who's who" for this chat room if you'd like: https://docs.google.com/spreadsheets/d/16h3jv24usMGq18495C-JA-yNcQCKiKDa65MTraNDd7k/edit?usp=sharing :)
13:48 thanh-thanh18
it's oki for me
13:50 pdurbin
ok, I just added you
13:50 pdurbin
:)
13:51 pdurbin
if you type "/topic" you can see the link to the who's who (and the logs)
13:54 thanh-thanh18
ah, oki, thx for the info
13:54 thanh-thanh18
:)
13:54 thanh-thanh18
I just make the pull request
13:54 pdurbin
hmm, I don't see it
13:55 thanh-thanh18
uhm, I re-check
13:55 thanh-thanh18
...
13:55 pdurbin
oh, I see what happened
13:56 pdurbin
you made the pull request against your fork
13:56 pdurbin
i think you can edit the destination or whatever they call it
13:56 thanh-thanh18
ah mez
13:56 pdurbin
the commit looks good! :)
13:57 pdurbin
https://help.github.com/en/articles/changing-the-base-branch-of-a-pull-request
13:57 pdurbin
or you can make a new branch and try again... whatever is easier. :)
13:58 thanh-thanh18
oki
13:58 thanh-thanh18
thx
13:58 pdurbin
git is not famous for being easy :)
14:12 thanh-thanh18
:(
14:12 thanh-thanh18
I can not change the base branch to the dataverse repo :(
14:12 pdurbin
T-T
14:12 thanh-thanh18
I make it as a "traditional" way
14:12 thanh-thanh18
checkout
14:12 thanh-thanh18
make change
14:13 thanh-thanh18
push upstream on new branch
14:13 thanh-thanh18
but has access denied
14:13 pdurbin
right, you have to push to your fork
14:14 pdurbin
at http://guides.dataverse.org/en/4.14/developers/dev-environment.html#clone-the-dataverse-git-repo ...
14:14 pdurbin
I suggest making a fork
14:14 pdurbin
and then cloning your fork
14:14 pdurbin
git clone git
14:15 pdurbin
so for you:
14:15 pdurbin
git clone git
14:15 pdurbin
that will make your fork the "origin"
14:16 pdurbin
and at http://guides.dataverse.org/en/4.14/developers/version-control.html#push-your-branch-to-github ...
14:16 pdurbin
I give this example: git push origin 3728-doc-apipolicy-fix
14:16 pdurbin
... with the idea that "origin" is your fork
14:17 pdurbin
Does that help? :)
14:31 donsizemore
@pdurbin quick question?
14:31 pdurbin
hit me
14:32 donsizemore
the filemetadata endpoint. i've tried both DB IDs and DOIs (with slashes?) on 4.9.4 and 4.14. everything returns a 404
14:32 donsizemore
what i'm do wrong?
14:32 pdurbin
hmm, can you please link me to where in the api guide you're looking?
14:33 donsizemore
http://guides.dataverse.org/en/latest/api/native-api.html#getting-file-metadata
14:34 thanh-thanh18
sorry, I was away a little bit
14:35 pdurbin
thanh-thanh18: no worries. Isn't git fun? :)
14:35 thanh-thanh18
if you're still there, I have my branch on the fork
14:35 pdurbin
donsizemore: those api endpoints were added recently.
14:35 thanh-thanh18
but I can not create the pull request @@ the branch do not show up @@
14:37 pdurbin
thanh-thanh18: I'm happy to coach you through this. Do you still have your "5855_Typo" branch locally?
14:37 thanh-thanh18
yup
14:38 pdurbin
great. let me give you some commands to try
14:38 pdurbin
git checkout 5855_Typo
14:38 pdurbin
git checkout -b 5855-guide-typo
14:38 thanh-thanh18
I'm on the branch
14:38 pdurbin
git push origin 5855-guide-typo
14:39 thanh-thanh18
uhm, I need to add -u to push the branch,
14:39 pdurbin
that's fine
14:39 thanh-thanh18
but wait, for dataverse or the fork ?
14:39 pdurbin
I'm trying to have you push to your fork.
14:39 pdurbin
Just the one commit that looked perfect.
14:41 stefankasberger joined #dataverse
14:41 thanh-thanh18
yes, I have push my new branch
14:42 pdurbin
ah, great, I see it: https://github.com/Thanh-Thanh/dataverse/tree/5855-guide-typo
14:42 pdurbin
what happens if you click "new pull request"?
14:42 pdurbin
the "base respository" should be "IQSS/dataverse" and "base" should be "develop"
14:43 thanh-thanh18
well
14:43 pdurbin
the "head repository" should be "Thanh-Thanh/dataverse" and "compare" should be "5855-guide-typo"
14:43 thanh-thanh18
I see what I didn't see :)
14:43 thanh-thanh18
sorry
14:43 thanh-thanh18
you see my pull request now I suppose ?
14:44 pdurbin
yes! https://github.com/IQSS/dataverse/pull/5857 looks perfect
14:44 pdurbin
oh, I guess I'll edit the description to link to the issue
14:45 pdurbin
done
14:45 thanh-thanh18
Thank you very much
14:45 pdurbin
I clicked approve.
14:45 thanh-thanh18
I need to make this clear to my team about this
14:45 thanh-thanh18
up till now, we do not work this way
14:45 thanh-thanh18
with the fork I mean
14:46 pdurbin
And now I'll drag it to QA on our kanban board at https://github.com/orgs/IQSS/projects/2
14:46 pdurbin
done
14:46 thanh-thanh18
Thanks for your time, it'll be interesting to work with you guys
14:47 pdurbin
You probably work the same way we do. You probably all push to the same repo under your org. You probably don't all maintain your own forks. It's more work to maintain your own fork.
14:47 pdurbin
You have to keep your fork up to date with "upstream" (with IQSS/dataverse).
14:48 pdurbin
You're very welcome. Thank you for the pull request! I'm sorry that was harder than I expected.
14:49 thanh-thanh18
honestly, we do not use "fork" at all
14:49 thanh-thanh18
lol
14:49 pdurbin
:)
14:49 thanh-thanh18
just master and branches
14:49 pdurbin
I don't blame you. Why bother if you don't have to. :)
14:49 thanh-thanh18
no, it just sometime to kick up
14:49 thanh-thanh18
we'll get used to it after one first time
14:49 pdurbin
If that "version control" page has some wrong or weird advice, please let me know.
14:50 pdurbin
I tried to write it for people who have to fork the IQSS repo.
14:50 pdurbin
like you :)
14:50 thanh-thanh18
oki, we'll read it and see whether we need more information
14:50 pdurbin
But I don't actually work that way. I just push to the IQSS repo.
14:50 thanh-thanh18
yup, cause u do not have an 403 :P
14:50 pdurbin
:)
14:50 thanh-thanh18
so, I need to go now,
14:50 pdurbin
thanks again!!
14:51 thanh-thanh18
I'll be back to you as soon as I have more information on how to proceed on our side
14:51 thanh-thanh18
it's me to need to thank :)
14:51 pdurbin
ok, I'm not usually here on weekends but next week is good
14:51 thanh-thanh18
me neither
14:51 pdurbin
good :)
14:51 thanh-thanh18
the soonest is next week
14:51 thanh-thanh18
have a nice weekend !
14:52 pdurbin
you too!
14:52 thanh-thanh18
hope to be able to get back to you soon
14:52 thanh-thanh18
bye
14:52 thanh-thanh18 left #dataverse
14:52 pdurbin
what a nice person
14:52 pdurbin
donsizemore: those new API endpoints for file metadata were added in 4.13: https://github.com/IQSS/dataverse/issues/5674
14:53 donsizemore
yeah, i'm trying it against 4.14 but can only get a 404 response, even using the DB ID
14:54 pdurbin
oh!
14:55 donsizemore
(what we're really after is a given file's MD5)
14:55 pdurbin
https://dataverse.harvard.edu/api/files/3371438/metadata works but doesn't show the md5 :(
14:55 pdurbin
{"label":"2019-02-25.tab","description":"","restricted":false,"id":2673158}
14:56 donsizemore
ooh, i can get that from the datasets api
14:58 pdurbin
true!
14:58 pdurbin
and lots more
14:59 donsizemore
now he says he doesn't need it...
14:59 pdurbin
heh
15:00 pdurbin
would love to talk about api tests (or next week) but I gotta bike to work
15:01 donsizemore
be safe! i've got the tests running (just failing)
15:30 pdurbin
... in the rain
15:30 pdurbin
donsizemore: nice! Should I go look?
15:30 pdurbin
hmm, still sunny at https://jenkins.dataverse.org
15:51 pdurbin
stefankasberger: thanks for the detailed explanation at https://github.com/AUSSDA/pyDataverse/issues/5#issuecomment-493431015 !
17:19 donsizemore joined #dataverse
17:19 donsizemore
@pdurbin i was trying to verify what i was or wasn't doing to make them fail before cobbling them into our jenkins setup
17:20 pdurbin
ah, ok
17:20 donsizemore
@pdurbin (even though i love the rain) https://www.youtube.com/watch?v=HrgifHhBphY
17:20 pdurbin
this reminds me that I should standup my own jenkins, or try to
17:21 donsizemore
@pdurbin and my next step, now that things have calmed down, was to duplicate phoenix VM hardware-wise and see how the test behaved (timing/race?)
17:21 pdurbin
ah, that makes sense
17:21 pdurbin
oh, I have a security related thing to talk to you about. not here
17:22 * pdurbin
looks at iqlogbot
17:22 pdurbin
it's full of fun russian text
17:23 pdurbin
Where *is* the right place for open source projects to talk about security? Should I call you?
17:23 pdurbin
It's not "hair on fire" but I'd like to discuss it today or next week.
17:23 donsizemore
@pdurbin i could join the IQSS slack?
17:24 pdurbin
there is a #dv-security channel in iqss slack
17:25 pdurbin
and a #dv-trsa channel, by the way
17:26 donsizemore
friday afternoon is not a time to be coy about potential security issues ;)
17:27 pdurbin
maybe I'll just pm you
17:38 pdurbin
for my reference (or other people with access) I'm talking about #276351
17:46 pdurbin
donsizemore: sorry to switch gears on you but I just had a thought on https://github.com/IQSS/dataverse/issues/2202 ... how hard would it be for you to send me some of those files that Dataverse hasn't been able to detect? Or should I just start poking around your installation and bumping up your download counts by grabbing them myself? :)
17:53 stefankasberger joined #dataverse
17:57 stefankasberger joined #dataverse
18:16 donsizemore
@pdurbin i've got the list of filenames. let me go back and look through that.
18:17 donsizemore
@pdurbin just got out of my 1:30 so ima look at "what we talked about" as well
18:18 donsizemore
@pdurbin or do you want me to pull out the identifier for all datafiles with contenttype unknown or whatever
18:21 pdurbin
donsizemore: I'm not sure what I want. Sorry. I was just looking at https://github.com/openpreserve/format-corpus . Being lazy, I think I just want a tarball or whatever of files that Dataverse can't identify. Files that are actually used in Dataverse installations, I mean.
18:22 donsizemore
@pdurbin what should i pull for you: protocol,identifier, then write a script to pull those files?
18:22 pdurbin
that's ok, if don't mind me downloading them and bumping up your counts I'll just grab them myself
18:22 pdurbin
if you*
18:23 donsizemore
you're welcome to download them, but i was going to make a list for you(?)
18:23 donsizemore
i say download away
18:23 pdurbin
that's ok, you gave me mandy's top 10 or whatever
18:23 pdurbin
I'll start there.
18:24 donsizemore
@pdurbin but my numerically sorted list of file extensions was in the ticket =)
18:24 pdurbin
heh, sure I'll look at that too :)
18:24 pdurbin
and the files from juancorr
18:24 pdurbin
all the files
18:24 pdurbin
what I'm actually looking at right now is http://guides.dataverse.org/en/4.14/api/native-api.html#set-citation-date-field-for-a-dataset ... do you ever use that api endpoint?
18:25 donsizemore
i'm realizing my query attempts aren't working because we turned off datafile pid registration
18:29 donsizemore
no, i've never used it
19:26 dataverse-user joined #dataverse
19:27 dataverse-user left #dataverse
19:32 asamy joined #dataverse
20:20 pdurbin
stefankasberger: some nice feedback from Jim on the round trip stuff: https://groups.google.com/d/msg/dataverse-community/07h0Ca-Ai1I/19U7Xlt7AwAJ
20:24 pdurbin
still raining
20:24 pdurbin
Have a great weekend, everyone!
20:24 pdurbin left #dataverse
