Time
S
Nick
Message
00:45 axfelix joined #dataverse
03:07 axfelix joined #dataverse
04:02 metamattj joined #dataverse
07:33 bencomp joined #dataverse
13:16 bencomp
Oops, is it that late already? https://github.com/bencomp/dataverse/commit/51cca8891ca1db44519802375ec29864758f95be
13:18 pdurbin
87 changed files with 175 additions and 313 deletions?! :) what are you up to?
13:19 bencomp
it's the more-generics branc
13:19 pdurbin
you're sure this is the right way to go?
13:19 pdurbin
how about we agree on a code quality tool first :)
13:20 pdurbin
none of us use Eclipse
13:20 pdurbin
here at Dataverse HQ :)
13:20 * bencomp
got carried away
13:20 pdurbin
heh
13:20 bencomp
at least I get "build success"
13:20 pdurbin
i'm just glad you're in the code! hope you're having fun!
13:20 pdurbin
huh. without those changes you can't build?!?
13:21 bencomp
sure I could
13:21 pdurbin
phew
13:21 bencomp
I mean i didn't break anything
13:21 pdurbin
ah. that's good :)
13:22 pdurbin
but I'm still not sure we need to get away from type inference... it's a feature of Java 7
13:22 pdurbin
diamond operator and what not
13:22 bencomp
but I found the use of addAll to add Dataverses and Datasets into one raw list interesting and hard to 'fix'
13:26 bencomp
https://github.com/IQSS/dataverse/pull/931/files#diff-51d2c584bd83f6c2c83d4023f31e8fccR189
13:27 bencomp
okay, I guess Eclipse doesn't know the <> very well
13:28 bencomp
it's not all that smart, because it sometimes changes some var to …<Object> when it's clear it should be <Dataset> or something
13:30 pdurbin
bencomp: can I convince you to try Netbeans? we like it a lot :)
13:31 bencomp
one of my colleagues is more fond of IntelliJ
13:32 bencomp
but I could try
13:32 pdurbin
yeah, I've heard good things about intellij
13:33 pdurbin
we all use netbeans
13:33 pdurbin
so if you use netbeans you'll see what we see
13:34 bencomp
if you all use v8.0.1 with the same settings :)
13:35 pdurbin
:)
13:35 pdurbin
I use the settings out of the box
13:57 bencomp
hmm, the nb project files probably need to be in the root of the dataverse repository, don't they?
14:06 bencomp
nevermind, I found the Import from Eclipse :)
14:06 LyndsySimon_ joined #dataverse
14:07 bencomp
have you tried swagger.io to create interactive documentation of the APIs?
14:17 bencomp
pdurbin: the Inspector in Netbeans is not bad at all
14:17 bencomp
"Missing javadoc" everywhere ;)
14:26 pdurbin
try Window -> IDE Tools -> Javadoc Documentation
14:26 pdurbin
bencomp: oh man, if you want to hook us up with swagger-based API docs, please do!
14:27 bencomp
I tried some things last night, but hit CORS problems
14:28 bencomp
it's not too hard - just add the right plugin and dependency to pom.xml
14:29 bencomp
still up to you to add javadoc
14:35 bencomp
pdurbin: with NetBeans: https://github.com/bencomp/dataverse/compare/IQSS:master...775-different-generics
14:42 pdurbin
Showing with 334 additions and 468 deletions?!?
14:42 pdurbin
bencomp: netbeans made all those changes?
14:43 bencomp
those include the Eclipse edits
14:43 pdurbin
oh
14:43 pdurbin
i'm just curious if netbeans complains as much as eclipse
14:43 bencomp
not sure if GitHub counts lines edited twice, twice
14:44 pdurbin
dunno
14:44 pdurbin
if you want us to merge a pull request, let's start with a small one :)
14:44 bencomp
it doesn't complain that I should remove type arguments and make things raw again
14:45 * bencomp
goes git rebase
15:02 axfelix joined #dataverse
15:42 bencomp
pdurbin: so I closed the pull request, but I am looking at creating a similarly big one. almost all changes are straightforward type arguments or import cleanups, but in the CommandHelper and ServiceRegistry there are some changes that I'm less sure about
15:45 bencomp
i.e. https://github.com/bencomp/dataverse/compare/775-different-generics?expand=1#diff-61 and https://github.com/bencomp/dataverse/compare/775-different-generics?expand=1#diff-80 (if that works for you)
15:59 pdurbin
yeah, all this generics stuff scares me
16:00 bencomp
it shouldn't :) it's much easier to spot errors if you have explicit typing
16:00 pdurbin
so you want more code and less type inference
16:03 bencomp
I want readable code or javadoc :)
16:03 pdurbin
we can write more javadoc :)
16:04 bencomp
good, but you need generics too
16:04 pdurbin
we have generics :)
16:05 pdurbin
public R execute( CommandContext ctxt )
16:05 bencomp
not enough, say NetBeans and Eclipse - and me
16:06 pdurbin
what's the error/warning from netbeans?
16:06 pdurbin
and on what line of what file can I find it?
16:10 pdurbin
bencomp: am I making sense?
16:10 bencomp
hmm
16:10 bencomp
yes, you are - I can't find the "raw type" warning in NetBeans
16:11 bencomp
that could only have been Eclipse and me then
16:11 pdurbin
:)
16:11 pdurbin
please show me the complaint from netbeans :)
16:12 pdurbin
or the command line tool of your choice
16:15 bencomp
I can get 152 occurrences of the "you could use the diamond operator here" warning on the current master
16:17 bencomp
but not "raw types are soooo 2002"
16:19 bencomp
gotta run!
16:23 pdurbin
:)
17:07 * pdurbin
leaves a comment: Add (diamond) type arguments to lots of files, clean up unused imports by bencomp · Pull Request #933 · IQSS/dataverse - https://github.com/IQSS/dataverse/pull/933
17:08 metamattj joined #dataverse
17:17 garnett joined #dataverse
18:53 balo joined #dataverse
19:41 metamattj joined #dataverse
20:20 freeman_ joined #dataverse
20:20 freeman_
hello
20:21 freeman_
question: is there a way for DVN 3.6.0 to allow data files uploaded to DVN to be available for the public from a certain date to an ending date ? if not that is alright. I don't think this is possible in version 4.0 as well.
20:30 axfelix joined #dataverse
21:16 metamattj joined #dataverse
21:22 axfelix joined #dataverse
22:07 bencomp joined #dataverse
23:05 axfelix joined #dataverse
23:26 iqlogbot joined #dataverse
23:26 Topic for #dataverse is now Dataverse: http://dataverse.org | logs at http://irclog.iq.harvard.edu/dataverse/today
23:46 pdurbin
whoops missed him
