Time
S
Nick
Message
00:13 JonathanNeal joined #dataverse
00:31 JonathanNeal joined #dataverse
00:39 LyndsySimon joined #dataverse
01:06 LyndsySimon joined #dataverse
01:10 sanchitgoyal joined #dataverse
01:44 axfelix joined #dataverse
02:06 JonathanNeal joined #dataverse
04:37 sanchitgoyal joined #dataverse
05:13 axfelix joined #dataverse
07:45 metamattj joined #dataverse
08:03 JonathanNeal joined #dataverse
11:51 bencomp joined #dataverse
11:54 sanchitgoyal joined #dataverse
12:45 skay joined #dataverse
12:56 skay joined #dataverse
12:56 skay joined #dataverse
14:00 freeman joined #dataverse
14:08 bencomp
pdurbin: just tried the Vagrant machine, but i see an error 'relation "guestbook" does not exist'
14:08 pdurbin
huh
14:08 bencomp
wait
14:08 bencomp
there are more errors
14:12 bencomp
seeing so many red lines is a bit confusing - it appears the guestbook error is the first real one
14:12 * pdurbin
runs `vagrant up`
14:14 pdurbin
this takes a while
14:14 pdurbin
bencomp: what problem are you trying to solve? :)
14:14 bencomp
afterwards I see many 404s from glassfish
14:15 bencomp
I was trying to see what the licence model looks like
14:15 pdurbin
ah. yeah, I don't think that has been pushed to the demo site yet
14:15 bencomp
can I create a custom licence for (sub)dataverses or datasets?
14:15 bencomp
indeed
14:16 pdurbin
I was thinking it would be nice to have https://apitest.dataverse.org updated with the latest code. Maybe that could be a place for you to poke around.
14:17 bencomp
we should get a server soon so that we can see if SURFconext via shib gives problems
14:17 pdurbin
yes, I'm highly interested in this
14:18 bencomp
I was working on the licences for the current dataverse.nl
14:18 pdurbin
my Vagrant is failing too but in a different way. It can't install the shibboleth RPM from http://download.opensuse.org
14:19 bencomp
it's fun, as the end-user terms need to fit the contracts we have with universities etc
14:19 bencomp
hmm
14:31 bencomp
I also got a port clash for 8888, but it was Glassfish
14:36 pdurbin
yeah, you can change the Vagrant port if you want. it's in the Vagrantfile
14:37 pdurbin
I guess I could disable the installation of shibboleth for now.
14:43 bencomp
pdurbin: is the DB pre-initiated? I don't see the schema definition
14:43 pdurbin
when glassfish deploys it creates the tables
14:43 bencomp
ah
14:44 pdurbin
"create-tables" in https://github.com/IQSS/dataverse/blob/master/src/main/resources/META-INF/persistence.xml
14:49 bencomp
strange that guestbook is not in the schema
14:50 pdurbin
well, hold on. my Vagrant is getting father along now
14:50 pdurbin
bencomp: you're saying you can't see the running app, right?
14:51 bencomp
correct
14:51 pdurbin
ok
14:52 bencomp
did I tell that I installed a CheckStyle plugin in Eclipse and with my slightly adapted config, it shows 32000 items (warnings + info) for the dataverse code? :P
14:54 pdurbin
:)
14:54 bencomp
I noticed JUnit tests that are empty and have as their documentation "Test of <method> of class <class>"
14:54 pdurbin
bencomp: I was just looking at your pull requests. No offense, but I'm planning on closing them since they were made against code that is quite old at this point.
14:56 bencomp
https://github.com/IQSS/dataverse/pull/935 could still be merged, even though some changes had already been applied, couldn't it?
14:59 bencomp
I'm not offended, but I hope the ideas behind them are clear :)
15:03 pdurbin
bencomp: I just let you a comment: https://github.com/IQSS/dataverse/pull/935/files#r22941440
15:04 pdurbin
oh, and my Vagrant is working. I can log in at http://localhost:8888
15:05 pdurbin
bencomp: the last message I see from Vagrant as part of the setup is this: {"status":"OK","data":{"message":"Metadata blocks of dataverse :root updated."}}
15:08 bencomp
I guess the deployment fails, because Glassfish is running and "blocking" the port that I set, causing Vagrant to say port forwarding failed
15:09 pdurbin
hmm, not sure about that
15:09 pdurbin
all that setup should be internal to the vagrant VM
15:09 pdurbin
the curl commands that do the setup hit port 8080 inside the vagrant VM
15:10 pdurbin
port 8888 is just so you can see the app from outside vagrant, from your laptop's browser or whatever
15:10 bencomp
port 4848 is internal only, right?
15:12 bencomp
there is no mapping in the Vagrantfile, so it should be
15:13 bencomp
I should stop doing this right now. I'm easily distracted...
15:15 pdurbin
:)
15:16 pdurbin
bencomp: hey, I just closed this other pull request with a note: https://github.com/IQSS/dataverse/pull/933#issuecomment-69930508
15:16 pdurbin
that's the one where 100 files were changed, which is too many at once
15:17 bencomp
100 files too many?! :D
15:17 bencomp
fyi, I put the logs of vagrant in https://gist.github.com/bencomp/69410c43ca71a42e713b
15:22 pdurbin
bencomp: hmm. you should definitely have a guestbook table. I do.
15:23 pdurbin
I'm assuming the inserts into the foreignmetadataformatmapping table were successful.
15:48 bencomp
there are 45 uses of System.out.println
15:50 pdurbin
bencomp: run `git blame` on them and see who it is :)
16:03 bencomp
pdurbin: it appears ellenk didn't get the memo ;)
16:03 pdurbin
:)
16:04 bencomp
and Michael
16:06 axfelix joined #dataverse
16:22 pdurbin
once we catch our breath I'll try to bring stuff like this up
16:53 metamattj joined #dataverse
17:33 sanchitgoyal joined #dataverse
19:02 sanchitgoyal joined #dataverse
19:17 sanchitgoyal joined #dataverse
22:58 sanchitgoyal joined #dataverse
23:22 axfelix joined #dataverse
