Time
S
Nick
Message
01:19 axfelix joined #dataverse
02:47 garnett joined #dataverse
03:41 axfelix joined #dataverse
05:00 sbmarks joined #dataverse
05:44 bencomp joined #dataverse
06:05 bencomp
I didn't think I'd see "Closed #775" this soon ;)
07:23 bencomp joined #dataverse
11:08 pdurbin
bencomp: please feel free to open individual issues
11:08 pdurbin
oh, and I mentioned your pull requests in our last meeting
11:08 pdurbin
bencomp: that reminds me, if you're interested in participating in some code review, please let us know!
11:14 pdurbin
I added something about this to the Google Doc linked from http://guides.dataverse.org/en/latest/developers/coding-style.html
12:50 bencomp
pdurbin: thanks, I probably will open some issues to follow up 775
12:50 bencomp
what came out of discussing my PRs?
12:51 bencomp
I've probably reviewed too much code already, but only on a high level ;)
12:51 pdurbin
at some point they'll be assigned
12:52 bencomp
good
12:53 bencomp
pdurbin: how realistic is releasing 4.4 one week after 4.3?
12:55 pdurbin
um
12:58 pdurbin
bencomp: good catch. I emailed internally about this just now. Thanks.
12:59 bencomp
we were hoping to go live with 4.3 given OAI-PMH and Handle
12:59 bencomp
I just noticed that these features went to 4.4
13:00 pdurbin
right, but
13:00 pdurbin
we're planning on starting work on that stuff in 4.3 even though the plan is to not ship them until 4.4
13:01 pdurbin
we have a new google doc that explains it
13:07 bencomp
pdurbin: do I have that document too?
13:07 donsizemore joined #dataverse
13:07 pdurbin
I don't think we've linked to it publicly yet. I think we're going to have a meeting about it this week.
13:08 bencomp
ok
13:08 pdurbin
donsizemore: mornin'
13:08 pdurbin
bencomp: but it sounds like Leonid and I will be working on those issues.
13:08 pdurbin
so if you have any guidance on any of it, please let me know
13:09 pdurbin
I've never worked with either before (OAI-PMH and Handle).
13:10 bencomp
DVN 3 has an OCLC library for OAI-PMH
13:10 bencomp
DVN 3 has code for dealing with Handle
13:11 pdurbin
hmm, didn't know we used a library
13:23 sbmarks joined #dataverse
14:22 bencomp
pdurbin: I think I'm about to open a Shib-related issue
14:24 pdurbin
bencomp: oh?
14:26 bencomp
it seems a user with multiple email addresses separated by semicolon ends up with an account with all addresses
14:26 axfelix joined #dataverse
14:27 bencomp
I cannot check in "account information" as it tells me to talk to my org, but when creating a dataverse the malformed address is pre-filled
14:28 bencomp
"Jordan.Belfort
14:28 bencomp
... is the validation result
14:30 pdurbin
bencomp: interesting. Have you played with "DebugShibAccountType" at http://guides.dataverse.org/en/latest/developers/dev-environment.html#shibboleth ?
14:32 bencomp
pdurbin: no, we connected our test server to SURFconext
14:32 bencomp
test dot dataverse.nl
14:33 pdurbin
nice!
14:33 bencomp
if you like to see for yourself, choose the SURFconext DIY IdP from the WAYF
14:33 pdurbin
yep, I'm looking now
14:34 bencomp
I logged in using professor1/professor1
14:35 pdurbin
me too
14:35 pdurbin
bummer that I can't see anything under "Account Information" :(
14:38 bencomp
I see in the db that the full email is stored
14:38 pdurbin
this is kind of related, I guess: https://github.com/IQSS/dataverse/issues/2046
14:38 bencomp
I figured https://github.com/IQSS/dataverse/issues/1608 is related
14:39 pdurbin
hmm, sort of, I guess
14:39 pdurbin
bencomp: please feel free to make a new issue
14:41 pdurbin
bencomp: yeah, now that I think of it more... it *is* related... I mean, how is the Dataverse installation supposed to know which email address is preferred?
14:42 pdurbin
so it's a lot like givenName
14:44 bencomp
how about the user is presented with a choice? "It looks like you have 2 email addresses. Which would you like us to use for notifications?"
14:51 pdurbin
that makes sense. for names, I just sort and pick the first one without asking: Shib: if multiple name values, use first (sorted) #1608 · IQSS/dataversehttps://github.com/IQSS/dataverse/commit/3f5d431
14:52 pdurbin
here are the tests: https://github.com/IQSS/dataverse/blob/3f5d431dab00f79d76cb591585a41994a355ebb1/src/test/java/edu/harvard/iq/dataverse/authorization/providers/shib/ShibUtilTest.java#L76
14:52 pdurbin
testFindBestFirstAndLastName
14:53 pdurbin
I feel like it's a bug that an email address with a semicolon in it was persisted.
14:54 pdurbin
let alone the two @ signs
14:56 bencomp
created https://github.com/IQSS/dataverse/issues/2512
14:57 donsizemore joined #dataverse
15:03 donsizemore
just saw your ticket about Shib and e-mail addresses, and love the confirmation suggestion in #1608
15:04 pdurbin
bencomp: thanks! I added a comment and screenshot
15:04 donsizemore
we're mapping out our upgrade process in relation to a conversion to Shib accounts
15:06 donsizemore
a number of our existing UNC accounts will be duplicated with a +1 on Shib login, so it'd be great for Dataverse to pick up the existing account instead
15:56 bencomp
pdurbin: do you recognise this log message?
15:56 bencomp
[2015-09-14T16:40:32.411+0200] [glassfish 4.1] [INFO] [jsf.non_displayed_message] [javax.enterprise.resource.webcontainer.jsf.renderkit] [tid: _ThreadID=51 _ThreadName=jk-connector(2)] [timeMillis: 1442241632411] [levelValue: 800] [[
15:56 bencomp
WARNING: FacesMessage(s) have been enqueued, but may not have been displayed.
15:56 bencomp
sourceId=dataverseForm:j_idt206:0:contactEmail[severity=(ERROR 2), summary=(Please enter a valid email address.), detail=(Please enter a valid email address.)]]]
16:06 axfelix joined #dataverse
16:09 donsizemore joined #dataverse
17:01 metamattj joined #dataverse
17:17 pdurbin
whoops, missed some stuff here when I wandered off to meetings
17:18 metamattj joined #dataverse
17:18 pdurbin
for the record, I don't recognize that message
17:18 pdurbin
and I'm not sure why some accounts would be migrated and not others. hmm.
17:19 axfelix joined #dataverse
17:21 metamattj joined #dataverse
17:26 cnk joined #dataverse
17:41 axfelix joined #dataverse
17:52 metamattj joined #dataverse
18:27 balo joined #dataverse
18:44 axfelix joined #dataverse
19:03 axfelix joined #dataverse
19:46 bencomp joined #dataverse
19:51 michbarsinai joined #dataverse
20:01 bencomp
pdurbin: mvn javadoc:javadoc just failed on my laptop with 100 errors and 100 warnings
20:02 bencomp
... or so Maven says, because the apidocs are generated
20:02 pdurbin
bencomp: hmm. I saw warnings but obviously, I was able to generate some HTML : http://dvn-vm1.hmdc.harvard.edu/tmp/javadoc/2015-09-14/bb695f3/apidocs/
20:03 pdurbin
michbarsinai: ohai!
20:03 pdurbin
michbarsinai: I was singing your praises today. You're better at writing Javadoc than the rest of us. :)
20:03 pdurbin
see https://github.com/IQSS/dataverse/issues/2513
20:05 michbarsinai
hello!
20:11 bencomp
pdurbin is right, when there's javadoc chances are michbarsinai wrote the code (and when there's no javadoc at all, it's pdurbin's code)
20:11 bencomp
at least at the class level
20:11 bencomp
;)
20:11 pdurbin
grr ;)
20:12 bencomp
I tried to do my part https://github.com/IQSS/dataverse/pull/2478/files
20:12 pdurbin
I write more javadoc than some :)
20:12 bencomp
true
20:13 michbarsinai
*blushing*
20:13 michbarsinai
I'm having fun here, setting up the home network.... resetting apple stuff...
20:13 michbarsinai
Got a time capsule as a hand me down :-)
20:13 pdurbin
today I discovered http://www.javadoc.io but it's only for stuff that's on maven central
20:16 michbarsinai
Is Maven somehting I should learn? I managed to avoid so far
20:16 pdurbin
michbarsinai: meh. netbeans handles all the maven stuff for you for the dataverse project
20:16 pdurbin
"just works" :)
20:17 michbarsinai
I just love NetBeans.
20:18 pdurbin
michbarsinai: then you should help me with https://docs.google.com/a/harvard.edu/document/d/102w_eDO-P06u_L0swChf-aFuTdnMRr6vtLG0HWbMvZo/edit?usp=sharing ! :)
20:19 michbarsinai
I know. It's on my list
20:19 michbarsinai
Is that for each team member who has a blog, or one for the entire team?
20:20 pdurbin
michbarsinai: for now, let just both add bullets until we get to at least 5 bullets :)
20:21 michbarsinai
Will do.
20:23 pdurbin
great
20:23 pdurbin
travis "just works" with maven too
20:26 pdurbin
michbarsinai: hmm. check out https://github.com/Mashape/unirest-java as a possible alternative to https://github.com/jayway/rest-assured
20:30 michbarsinai
Looking good!
20:30 pdurbin
well, except that it isn't oriented toward testing, it seems
20:31 pdurbin
anyway, gotta pick up the kids. have a good one, all
20:40 bencomp
aju!
20:42 bencomp
I installed the Selenium IDE in my Firefox today. That should come in handy :)
20:43 michbarsinai
bye1
20:43 michbarsinai
!
20:44 michbarsinai
Not sure how well Selenium plays with JSF, though
20:45 michbarsinai
You need to be careful about your control selectors (it's a 4 year old info, so maybe they play well together now)
20:48 michbarsinai
OK. I'm calling it a day. See ya'll!
20:48 michbarsinai left #dataverse
20:50 cnk joined #dataverse
20:54 axfelix joined #dataverse
21:17 metamattj joined #dataverse
21:32 metamattj joined #dataverse
22:33 axfelix joined #dataverse
22:48 garnett joined #dataverse
