Time
S
Nick
Message
02:30 Guest5048 joined #dataverse
06:51 juancorr joined #dataverse
08:45 poikilotherm joined #dataverse
09:34 pdurbin
poikilotherm: hi. It looks like you saw my comment: https://github.com/IQSS/dataverse/pull/6146#issuecomment-530117684 :)
09:58 poikilotherm
Hi pdurbin :-D
09:58 poikilotherm
Yeah I saw it
09:59 poikilotherm
I was like "OMG", "wait, what?" and then "hmm ok let's see what Phil will tell me about it"
10:00 poikilotherm
Because "We went over this pull request a bit during tech hours this afternoon. Please stay tuned." leaves lots of space for interpretation :-D
10:02 pdurbin
I was just glad that people were curious enough to ask about the details. :)
10:02 poikilotherm
O rly?
10:02 poikilotherm
O.o
10:03 poikilotherm
Did I strike a chord?
10:04 pdurbin
Sort of. Most of this Solr stuff has been left to me so I'm glad you're interested and helping.
10:21 poikilotherm
Anything that needs changing? Discussion? More reviews? Or just kcondons valuable time for testing and merging?
10:21 pdurbin
kcondon always wants to know about risk and change. Do you think that's been communicated well enough?
10:22 poikilotherm
Good point
10:22 poikilotherm
Maybe this is also sth. that needs to be more discussed about PRs
10:22 poikilotherm
(Regarding issue 5845
10:23 poikilotherm
Maybe people opening a PR should add a few words about risks and critical points
10:23 poikilotherm
For #6142 I dunno if we communicated this well enough
10:23 pdurbin
yeah, the template could be better
10:23 poikilotherm
We did not talk about upgrades
10:23 poikilotherm
What should people do when upgrading to the latest release
10:24 poikilotherm
Are there risks for existing installations
10:24 poikilotherm
Maybe we should add a release note?
10:26 poikilotherm
Oh BTW. I renamed the script, but I did not change the xml file names
10:26 poikilotherm
Shall we do this, too?
10:32 pdurbin
Do you know about /doc/release-notes from http://guides.dataverse.org/en/4.16/developers/making-releases.html#write-release-notes ?
10:32 poikilotherm
Yeah
10:33 pdurbin
Oh, you didn't change the XML file names? Should we pull it out of QA so you can do that?
10:33 poikilotherm
Dunno
10:33 pdurbin
Now's the time, right?
10:33 poikilotherm
If we need to add more stuff like release notes we should do that anyway, right?
10:33 poikilotherm
Sure :-D It's still for early birds at your place :-D
10:34 pdurbin
Yeah, we shouldn't be basing on a branch that's in QA. Kevin asked me to merge the lastest from develop and to link up the script from the guides.
10:34 pdurbin
You can pull it out of QA yourself?
10:34 poikilotherm
I think so
10:35 pdurbin
Cool. Can you change assignees?
10:35 poikilotherm
Placed it in Code Review again
10:35 poikilotherm
Nope
10:36 poikilotherm
Shall I move #6133 myself, too?
10:36 pdurbin
Ok, I assigned you. And yes, you have many hours before you need to worry about anyone testing it.
10:37 pdurbin
The maven offline support one? Sure.
10:38 poikilotherm
Ok Done
10:38 pdurbin
and I took you off it
10:38 pdurbin
actually, you should probably move it to code review
10:38 pdurbin
and I can move it to QA
10:38 pdurbin
people pay attention to these things
10:40 poikilotherm
Too late - the moment you wrote it I did it :-D
10:40 pdurbin
But do you see what I mean?
10:40 poikilotherm
But I changed my comment to note that we talked about it
10:40 poikilotherm
Of course
10:40 pdurbin
ok
10:40 poikilotherm
That's why I asked you in my comment :-D
10:41 pdurbin
I just re-moved it with a review.
10:43 poikilotherm
*thumbs up*
10:48 pdurbin
What do you think of this? https://github.com/thelounge/thelounge/issues/3398
10:53 poikilotherm
Interesting
11:02 poikilotherm
TheLounge itself looks promising
11:02 poikilotherm
It has a lot of stuff I miss from most IRC clients
11:03 poikilotherm
It would be really awesome to have some bot that spits out github links
11:04 poikilotherm
It be also very fancy to have some github bot linking to IRC with a command which posts a link in IRC to the comment
11:14 pdurbin
I stood up The Lounge in Docker on my home server over the weekend. One fun feature we would get is emoji support. If anyone here wants, I can start it up so you can play with it.
11:16 pdurbin
I even started making a The Lounge theme for Dataverse. :)
11:17 poikilotherm
Here here here
11:17 poikilotherm
I am a willing test pilot
11:18 pdurbin
Actually, let me try https://demo.thelounge.chat first
11:19 pdurbin2 joined #dataverse
11:19 poikilotherm
pdurbin any chance you could create another review for #6142/#6146?
11:19 pdurbin2
😄🎉emojis!
11:20 poikilotherm
Hehehe - Konversation, my IRC client, has UTF -8 emojis support, so I see those :-)
11:20 pdurbin
They're shown in the logs too! http://irclog.iq.harvard.edu/dataverse/2019-09-11#i_105301
11:20 *Â pdurbin
gives iqlogbot a treat
11:21 poikilotherm
BTW: iqlogbot web view has a bug when jumping between month
11:21 poikilotherm
You cannot go from 8/31 to 9/1
11:21 poikilotherm
Or reverse
11:23 pdurbin
Yeah, I fixed that upstream in philbot.
11:23 pdurbin
But iqlogbot isn't technically running the philbot code.
11:23 poikilotherm
Yeah
11:23 poikilotherm
That's just the IRC client ;-)
11:24 poikilotherm
I meant the web interface
11:24 pdurbin
I know. It's all the same codebase.
11:24 poikilotherm
Ok :-)
11:24 pdurbin
here's the fix: https://github.com/pdurbin/philbot/commit/9d358be134ad1a42793832068fab8b421af39764
11:25 pdurbin
Please feel free to open an issue about this at https://github.com/IQSS/chat.dataverse.org/issues
11:42 pdurbin
poikilotherm: did you push any new commits? I don't see any at https://github.com/IQSS/dataverse/pull/6146/commits . I thought you were going to rename those XML files
11:43 pdurbin
Also, what about the Perl "install" script. Do you use it?
11:49 poikilotherm
Sry pdurbin I was going to ask you if you could create a list of stuff we should adress
11:49 poikilotherm
Like renaming
11:49 poikilotherm
You might have a better understanding if and what we should add to release notes
11:49 poikilotherm
And maybe other docs about risks etc
11:50 poikilotherm
The install script - nope.
11:50 poikilotherm
I'm not sure if it copies the solr stuff
11:50 poikilotherm
IIRC solr is before that, right? And I added docs for the XML files in the install guide
12:05 pdurbin
Yeah, I just looked at that Perl script. I think all it does is let you set the hostname and port for Solr. So I think we're fine.
12:07 pdurbin
I think renaming is those XML files is the main thing.
12:08 pdurbin
I can think out loud about risks and changes, I guess.
12:09 pdurbin
For existing installations, I don't think there's much risk. We aren't currently telling them (in future release notes) that they should reconfigure Solr to use the new include files. Do you think we *should* tell them to do that?
12:19 donsizemore joined #dataverse
13:01 pdurbin
donsizemore: try the emojis
13:06 poikilotherm
Re :-)
13:06 poikilotherm
Yeah we should tell them
13:07 poikilotherm
Because using the script etc will make their life easier for custom metadata schemas
13:14 poikilotherm
Ok I renamed
13:15 poikilotherm
And obviously also changed all references in docs, etc etc etc
13:40 pdurbin
The rename commit looks good. Do you want to stub out a release notes doc?
13:46 poikilotherm
ok
13:46 pdurbin
thanks!
13:57 poikilotherm
Go take a look :)
13:57 *Â pdurbin
pulls
13:58 pdurbin
You don't mind if I hack on this, do you?
13:59 poikilotherm
Go ahead. I wasn't sure what and how I should write this. Whom to adress etc
13:59 poikilotherm
Go delete it if it doesn't fit :-D
13:59 poikilotherm
I'm happy with whatever you guys are, too
14:00 pdurbin
Well, Danny takes these fragments and turns them into real release notes like this: https://github.com/IQSS/dataverse/blob/v4.16/doc/release-notes/4.16-release-notes.md
14:01 poikilotherm
Yeah, I was aware of this, so I tried to do something usefull for him
14:01 poikilotherm
Not sure I succedded
14:01 pdurbin
Yes, what you've written is great. I'm just wondering if you want me to bash on your branch directly or if you want me to make a pull request into your branch.
14:02 poikilotherm
Go grab that cludge and smash 'em
14:02 poikilotherm
(Just learned about "cludge" today :-D)
14:03 poikilotherm
It's funny when you know the german word "klatschen", which normally means "clapping hands" or "applaud"
14:03 poikilotherm
In slang it might mean "beat someone up"
14:04 poikilotherm
It sounds almost the same :-D
14:04 poikilotherm
(as cludge)
14:06 pdurbin
Hmm, I'm more familiar kludge than cludge. :)
14:07 poikilotherm
Hehehe
14:08 poikilotherm
I gave some translators a really hard time about that word
14:09 poikilotherm
pdurbin what am I doing wrong?
14:09 pdurbin
I'm the king of kludges.
14:09 poikilotherm
http://irclog.iq.harvard.edu/search.pl?channel=dataverse&nick=poikilotherm&q=kludge
14:09 donsizemore
@pdurbin speaking of kludges, i'm about to make an initial pull request for dataverse-jenkins-in-ec2 then we can become more feature-ful
14:09 poikilotherm
Ok nothing
14:10 poikilotherm
Just my failure
14:10 poikilotherm
Mornin' donsizemore
14:10 donsizemore
@poikilotherm how are you, sir!
14:11 poikilotherm
donsizemore: I'm fine, thank you. Its 16:10 here, so near quitting time
14:11 poikilotherm
I do hope I see #6146 merged 'till the end of the day :-D
14:12 pdurbin
poikilotherm: me too. And we should work on SMACKI: https://scholar.harvard.edu/pdurbin/blog/2019/jupyter-notebooks-and-crazy-ideas-for-dataverse
14:14 pdurbin
donsizemore: fantastic!!
14:15 donsizemore
@pdurbin if you can send me certs for jenkins-whatever.dataverse.org i'll drop an apache proxy in place
14:15 pdurbin
Perfect. What should we call this one?
14:16 donsizemore
api-test-suite.dataverse.org ;)
14:16 donsizemore
though i think that DB deadlock is the ultimate answer
14:25 pdurbin
I was thinking maybe jenkins2.dataverse.org
14:26 pdurbin
But I'm fine with whatever.
14:36 donsizemore
jenkins2.dataverse.org is great. i'll send you a CSR?
14:42 pdurbin
donsizemore: please! And sorry, I'm in design meeting talking about the four new issues opened by this person: https://github.com/IQSS/dataverse/issues/created_by/alejandratenorio
14:44 poikilotherm
Hihihihihihihihihi
14:44 poikilotherm
I saw those and was confused about the approach :-D
14:46 poikilotherm
OK guys I'm outta here... Hunting for kids
14:46 poikilotherm
Cu
14:53 donsizemore
@pdurbin i'm good, i'm plunking along here
15:00 pdurbin
Ok, I'm doing two dozen things at once. Not very well.
15:00 donsizemore
i can generally handle 3 as long as one of them doesn't involve human speech
15:12 pdurbin
teach me your ways
15:25 donsizemore
@pdurbin I'm going to cobble together some documentation in my Jenkins branch, but... well, I've got some design questions for you and Gustavo this afternoon
15:31 donsizemore
@pdurbin and if you'd like to follow along at home: http://ec2-34-228-111-141.compute-1.amazonaws.com:8080/job/IQSS-Dataverse-Develop/1/console
15:33 donsizemore
hmm, except the XML source i used wasn't current...
15:49 donsizemore
@pdurbin is there a way to delete individual files via API ?
15:49 donsizemore
@pdurbin _published_ files...
17:34 donsizemore joined #dataverse
18:25 pdurbin
donsizemore: yes, but only via SWORD
18:26 donsizemore
@pdurbin we seem to be blowing up validating version 1 of the dataset (which dates back to DVN 3.6)
18:26 pdurbin
you're running the validation checker thing
18:26 pdurbin
?
18:27 donsizemore
ooh, good call
18:27 donsizemore
can you link to the API guide page? i can't search it ;)
18:27 donsizemore
i'll grep the source
18:28 pdurbin
http://guides.dataverse.org/en/4.16/admin/dataverses-datasets.html#diagnose-constraint-violations-issues-in-datasets
18:29 donsizemore
ooh ooh. this is wonderful
18:29 donsizemore
except we're still on 4.11
18:30 pdurbin
We just upgraded to 4.16 yesterday :)
18:30 donsizemore
although Dataverse is indeed complaining that archiveNote is not a valid URL
18:31 donsizemore
and in pulling archiveNote entries which aren't null, most say "Replaced by version n"
18:32 donsizemore
in fact, we have 570 dataset versions for which archiveNote is "Replaced by version"
18:39 pdurbin
When you say, blowing up validation... what do you mean?
18:43 donsizemore
as the API guide example suggests, Dataverse is pissed that archiveNote isn't a valid URL
18:43 donsizemore
(the end result is that Mandy can't modify a dataset)
18:44 donsizemore
and all the matching archiveNote fields predate Dataverse 4
18:47 pdurbin
You're seeing the example from the API Guide. Ok. How do you fix it?
18:49 donsizemore
if i had to do it myself, i'd make the archiveNote field in those 518 dataset versions NULL like the other ~26000
18:49 pdurbin
sounds fine :)
18:49 donsizemore
but i opened a support ticket because i want to know the right thing to do (which may be to make them NULL, i just want to be told to do so)
18:50 pdurbin
ok
19:07 donsizemore
@pdurbin gustavo lookin for you
19:21 pdurbin
donsizemore: Â Clean up VersionNote, ArchiveNote, DeaccessionLink in DatasetVersion #5767 https://github.com/IQSS/dataverse/issues/5767
19:25 pdurbin
500 error when running DatasetsIT.testCreateDataset #6150 https://github.com/IQSS/dataverse/issues/6150
20:48 pdurbin
donsizemore: while I'm in there maybe I'll mint a cert for dev1 and dev3 :)
22:41 poikilotherm2 joined #dataverse
22:41 poikilotherm2
Greetings
22:41 poikilotherm2
I do hope people are still around...
22:46 poikilotherm2
Meh. Good night everyone.
22:46 poikilotherm2 left #dataverse
23:53 pdurbin
'night
