Time
S
Nick
Message
07:34 Virgile joined #dataverse
10:03 Virgile joined #dataverse
12:24 donsizemore joined #dataverse
12:26 Virgile joined #dataverse
12:32 Virgile joined #dataverse
12:57 Virgile joined #dataverse
14:47 pdurbin joined #dataverse
14:54 donsizemore joined #dataverse
17:12 poikilotherm
What's up folks
17:13 poikilotherm
My workhours shifted due to COVID-19 struggles (not me)
17:35 poikilotherm
pdurbin do you remember seeing warn log messages in server.log about "Unsupported deployment descriptors element message-destination value null"?
17:35 poikilotherm
Seeing a lot of those in latest develop
17:40 pdurbin
I don't remember one way or the other. Off to lunch.
18:44 poikilotherm
pdurbin I just enhanced the dev docs about mpconfig A LOT. HTH with the "why should I bother" part of your short review from earlier today. https://github.com/IQSS/dataverse/pull/7463/commits/5f73b45a6822083265e4226f8589000c03076a1c
18:47 poikilotherm
pameyer donsizemore happy for feedback from you folks, too. You don't profit as devs, but all this is with sysadmins in mind (and being a sysadmin, too, I want to be more lazy when it comes to config...)
19:03 pdurbin
poikilotherm: thanks, I'll take a look.
19:10 pdurbin
poikilotherm: this reminds me a lot of https://guides.dataverse.org/en/5.2/developers/dependencies.html
19:11 pdurbin
It's sort of... prescriptive.
19:27 pdurbin
Also, the tests are failing.
19:27 pdurbin
poikilotherm: so I sent you a "request changes" review.
19:28 pdurbin
donsizemore: I have no idea what we'd need to do on the Jenkins (or Ansible?) side to get those tests passing.
19:29 donsizemore
@pdurbin lemme look
19:30 pdurbin
donsizemore: here's my review with a link to a Jenkins console log: https://github.com/IQSS/dataverse/pull/7463#pullrequestreview-547559441
19:30 pdurbin
the log: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-7463/4/console
19:30 pdurbin
[ERROR] AliasConfigSourceTest.getValue:25 » IllegalState javax.naming.NoInitialContext...
19:31 pdurbin
[ERROR] AliasConfigSourceTest.readImportTestAliasesFromFile:39 » IllegalState javax.na...
19:33 donsizemore
this isn't Ansible, this is 'mvn package'
19:33 pdurbin
Ok, so maybe some dependency is missing? It works on my laptop.
19:38 donsizemore
gimme a sec
19:42 donsizemore
it's the profile flag. a straight 'mvn package' fails.
19:46 pdurbin
donsizemore: ah, you're right. `mvn package` fails on my laptop too.
19:47 pdurbin
`mvn -P tc verify` is the thing that works on my laptop.
19:47 donsizemore
Ansible (or anything else) can pass a profile flag if we tell it a default (and how to know which profile to use)
19:47 donsizemore
yes, that worked on my Ubuntu box as well
19:48 pdurbin
Well, we need `mvn package` to keep working. Let's see what poikilotherm says.
19:49 donsizemore
`mvn -P tc package` works. we just need to know how to pass it which profile
19:50 poikilotherm
Meh. Those didn't fail when I ran them on my laptop yesterday. Looks like microbean is picking up the DBSettingConfigSource now, which is failing for obvious reasons (no context in unit test)
19:53 pdurbin
ah
20:00 poikilotherm
Fix pushed. Simply leaving the config source empty if the datasource is not available. Should be OK during testing. Will log warning if not found, so this should be findable in real deployments
20:01 dataverse-user joined #dataverse
20:02 dataverse-user
Hello, has anyone here seen Microsoft is using Dataverse as their new software name?
20:03 dataverse-user48 joined #dataverse
20:04 dataverse-user48
https://powerplatform.microsoft.com/en-us/dataverse/
20:04 dataverse-user48 left #dataverse
20:08 pdurbin
yes, people are working on it
20:10 pdurbin
poikilotherm: ok, `mvn package` works now. Thanks.
20:17 poikilotherm
pdurbin it looks like I did sth. bad. I can deploy develop, but not this shiny branch. Most likely sth messed up with adding new MPCONFIG sources :-/
20:18 pdurbin
:(
20:18 pdurbin
T-T
20:18 poikilotherm
pdurbin when you deploy local, do you see those pesky "Unsupported deployment descriptors element message-destination value null." in latest stable (5.2) or is this in develop only?
20:20 pdurbin
I haven't noticed.
20:21 poikilotherm
Should we take a look? Or am I worrying too much?
20:23 pdurbin
You're welcome to create an issue if you'd like.
20:23 poikilotherm
Doh! I found the troubles with 7457 not deploying. It's just the same thing that broke tests, too. OK will need to transform the source into a bean and inject the datasource...
20:47 bjonnh joined #dataverse
21:51 pdurbin left #dataverse
