Time
S
Nick
Message
00:00 pdurbin
adil: hello
00:01 axfelix joined #dataverse
00:01 adil
jnn
00:01 adil
:-D
00:01 adil
:-D:-(:-(:-(
00:01 adil left #dataverse
01:49 axfelix joined #dataverse
02:57 axfelix joined #dataverse
03:14 garnett joined #dataverse
06:23 metamattj joined #dataverse
07:38 bencomp joined #dataverse
08:14 Juan_ joined #dataverse
08:14 fgb62 joined #dataverse
08:17 metamattj joined #dataverse
08:21 Juan_ left #dataverse
11:01 romainM joined #dataverse
11:01 romainM
hello
11:10 pdurbin
romainM: hi
14:34 pdurbin
bencomp: I just left comments on a couple of your pull requests.
14:35 bencomp
pdurbin: thanks.
14:40 pdurbin
bencomp: do you know if it's possible to change the branch from 4.2 to 4.3? 4.2 is tagged. no more commits should got into the 4.2 branch
14:43 bencomp
it's not
14:43 bencomp
pdurbin: but in my reply to your comment I provided a tip for dealing with it ;)
14:55 pdurbin
bummer that it's not possible. I guess we'll have to close it per my latest comment: https://github.com/IQSS/dataverse/pull/2478
15:08 bencomp
bummer indeed
15:09 bencomp
so what are the chances of PRs getting merged before the next version branch is deleted?
15:09 pdurbin
I guess the way we're doing things now... contributors have to be very aware of the dev cycle... how close to being merged and tagged a release branch (such as 4.2) is
15:10 bencomp
https://github.com/IQSS/dataverse/pull/2423 was created July 31
15:11 bencomp
and 2478 on August 23, i.e. over a month ago
15:11 pdurbin
yeah. and we merged and tagged 4.2 two days ago. hmm
15:11 pdurbin
"If your pull request is not assigned to anyone in a timely manner, please reach out." https://github.com/IQSS/dataverse/blob/v4.2/CONTRIBUTING.md
15:12 bencomp
https://github.com/IQSS/dataverse/pull/2423 was assigned on August 3 and sekmiller only responded through you, today, maybe?
15:13 axfelix joined #dataverse
15:14 pdurbin
bencomp: he looked at it a while ago but it sounds like there were too many changes in https://github.com/IQSS/dataverse/pull/2423/files to seem non-risky. Did you test the changes? :)
15:16 bencomp
no, I didn't
15:16 pdurbin
so it's risky
15:17 bencomp
let me finish my comment
15:20 pdurbin
bencomp: ok. I just pushed the change I mentioned that pull request if you're interested: add jsonAsDatasetDto method for exporting DDI #2579 · IQSS/dataversehttps://github.com/IQSS/dataverse/commit/3fa9856
15:31 bencomp
https://github.com/IQSS/dataverse/pull/2423#issuecomment-144447264
15:32 bencomp
pdurbin: you realise your commit is much bigger than my PR, right?
15:32 bencomp
:)
15:33 * bencomp
tries to keep smiling
15:33 pdurbin
bencomp: aw. sorry, man. I'm not trying to bum you out :(
15:33 pdurbin
I'm reading your comment now.
15:34 bencomp
pdurbin: don't take it personal
15:34 pdurbin
bencomp: it's really good feedback. We *don't* want contributors to be turned off from making contributions.
15:36 bencomp
good, as I'm trying to get DANS to make some contributions in work time
15:37 bencomp
and it would be nice if they found their way into the "upstream"
15:38 pdurbin
bencomp: if nothing else, you can point to that pull request as an example of what you're talking about with regard to type safety. You could add a link to it from the Google Doc linked from http://guides.dataverse.org/en/latest/developers/coding-style.html . It's a great example.
15:43 pdurbin
bencomp: it would be fantastic if you could get paid to help us with the Dataverse code.
15:43 bencomp
pdurbin: not me though, I'm just the back office/helpdesk
15:44 bencomp
should you update coveralls.io to use 4.3 as main branch?
15:45 pdurbin
I should... I'm not sure how.
15:47 pdurbin
"Repo info changed? Sync the location, privacy setting, and default branch of this repo with Github."
15:48 bencomp
add it to the dev guide :)
15:48 * pdurbin
clicks "Sync"
15:48 pdurbin
it worked! :)
15:48 bencomp
"5%" !
15:48 pdurbin
heh
15:49 pdurbin
we can only go up from here :)
15:49 bencomp
no, you don't
15:49 pdurbin
oh hush
15:49 pdurbin
:)
15:50 bencomp
especially in this respect you should not take my comments personal
15:51 pdurbin
heh. I know I'm writing tests. :)
15:52 bencomp
if other committers increase coverage it's probably because they deleted lines of code
15:52 bencomp
unless it's Michael :)
15:53 pdurbin
heh
15:54 bencomp
I'm off
15:54 bencomp
I'll await Gustavo's email :)
16:04 michbarsinai joined #dataverse
16:15 * pdurbin
eyes michbarsinai
16:15 pdurbin
here comes trouble
16:15 michbarsinai
Yay! Trouble!
16:16 pdurbin
heh
16:16 michbarsinai
(I'm working with lots of Python code now, configured with yaml. You can't scare me :-)
16:17 pdurbin
sounds like heaven for someone we know :)
16:18 pdurbin
michbarsinai: did you magically appear to tell me why both datasetDto.getDataFiles() and datasetDto.getDatasetVersion().getFileMetadatas() are always null? :)
16:18 pdurbin
I think I need to go for a walk.
16:19 michbarsinai
It's been a while since I've looked at those.
16:19 michbarsinai
Also, not even him would enjoy ROS =:-O
16:20 pdurbin
ROS?
16:21 michbarsinai
Robot Operating System. An open-source set of services written for robots.
16:21 pdurbin
michbarsinai: maybe you magically appeared to comment here like I asked: https://github.com/IQSS/dataverse/commit/3fa98562742221c86198fe765a4aa040040102e1#commitcomment-13520762 :)
16:21 michbarsinai
Think of R, but in Python and C++
16:21 michbarsinai
Or, don't, you already have to go for a walk :-)
16:21 pdurbin
heh, soon
16:22 michbarsinai
Let me pull the code for a sec...
16:22 pdurbin
michbarsinai: you'll love it. I just added tests that don't require a runtime. no need for glassfish or postgres
16:23 michbarsinai
Nice
16:23 michbarsinai
So, datasetDto never returns a version?
16:25 michbarsinai
Ellen have done some work on it...
16:26 michbarsinai
d8b5f1b
16:26 michbarsinai
https://github.com/IQSS/dataverse/commit/d8b5f1b
17:06 pdurbin
michbarsinai: no, sorry. I should be more clear
17:08 pdurbin
michbarsinai: I'm working on being able to change filesMinimallySupported to true in the testJson2ddiHasFiles test: https://github.com/IQSS/dataverse/blob/3fa98562742221c86198fe765a4aa040040102e1/src/test/java/edu/harvard/iq/dataverse/export/ddi/DdiExportUtilTest.java#L36
17:09 michbarsinai
????
17:09 michbarsinai
ok
17:10 garnett joined #dataverse
17:16 pdurbin
michbarsinai: can you change that to true locally and run the tests? should fail :)
17:22 michbarsinai
1 sec
17:22 bencomp joined #dataverse
17:23 michbarsinai
fails (yay?)
17:23 pdurbin
:)
17:23 pdurbin
michbarsinai: do you see the expected vs. actual XML ?
17:24 michbarsinai
yes
17:24 metamattj joined #dataverse
17:25 pdurbin
so I'm trying to get "trees.png" out of the json/dto
17:26 michbarsinai
Just that, or the entire otherMat node?
17:26 pdurbin
well, the entire thing. to make the test pass
17:30 michbarsinai
Strange... where is the otherMat element created?
17:30 pdurbin
I have to write it. This is test-first development. :)
17:31 michbarsinai
oh
17:32 cnk joined #dataverse
17:32 michbarsinai
nice methodology. I thought I wasn't reading Java properly anymore
17:32 pdurbin
heh
17:32 michbarsinai
(4 hourse of intensive Python, plus linux configs)
17:32 michbarsinai
*hours
17:33 pdurbin
trees.png is in JSON but I can't seem to find it in any DTO
17:36 michbarsinai
Not sure there are any DTOs involved - this test takes a JSON , and converts it to XML .
17:36 michbarsinai
I think
17:41 pdurbin
michbarsinai: it turns the JSON into DTOs
17:43 michbarsinai
on line 30 it's a String
17:43 michbarsinai
datasetCersionAsJson, is a Strgin
17:43 michbarsinai
String
17:44 michbarsinai
then, on 34, result is String
17:44 michbarsinai
Ok, I see, it's in the util. Sorry
17:44 michbarsinai
But its created using reflection....
17:45 pdurbin
`gson.fromJson(datasetDtoAsJson, DatasetDTO.class)` uses reflection?
17:46 michbarsinai
http://google-gson.googlecode.com/svn/trunk/gson/docs/javadocs/index.html
17:46 pdurbin
who knew
17:46 michbarsinai
Yep... must be ignoring nonexistent firlds.
17:46 michbarsinai
fields
17:47 michbarsinai
I gotta go, we can continue by mail
17:47 pdurbin
michbarsinai: no worries. you've given me some ideas. thanks!
17:48 pdurbin
I can definitely see them at cat src/test/java/edu/harvard/iq/dataverse/export/ddi/dataset-spruce1.json | jq .datasetVersion.files
18:11 pdurbin
got it! :) weird
19:15 pdurbin
the commit: get file id and names from JSON /DTO for DDI #2579 · IQSS/dataversehttps://github.com/IQSS/dataverse/commit/ec6998a
20:04 garnett joined #dataverse
22:49 axfelix joined #dataverse
23:29 metamattj joined #dataverse
